Fix incorrect painting of global FX bypasses #4893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes surge-synthesizer#4892 Also fixes color of send 3/4 sliders in Dark skin.
baconpaul
reviewed
Aug 23, 2021
src/gui/widgets/EffectChooser.h
Outdated
| return true; | ||
| break; | ||
| case fxb_scene_fx_only: | ||
| if (fxslot > 3) | ||
| if ((fxslot >= fxslot_send1 && fxslot == fxslot_global2) || |
There was a problem hiding this comment.
Did you really mean al == in the second?
This will only be true for fxslot == global2 or global 4
I think you mean >= fxslot_send1 && <= fxslot_global2
There was a problem hiding this comment.
yeah you definitely meant <=. Pushed a fix to your branch and will merge. Good catch!
There was a problem hiding this comment.
Yes that was an unfortunate typo, I did mean to cover the range so <= was definitely needed there 🙂
|
think it has a tiny bug? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4892
Also fixes color of send 3/4 sliders in Dark skin.