Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect FX bypasses after slot expansion #4892

Closed
mkruselj opened this issue Aug 22, 2021 · 0 comments · Fixed by #4893
Closed

Incorrect FX bypasses after slot expansion #4892

mkruselj opened this issue Aug 22, 2021 · 0 comments · Fixed by #4893
Labels
Bug Report Item submitted using the Bug Report template UI Issues related to UI look&feel
Milestone
Surge XT 1.0

Comments

@mkruselj
Copy link
Collaborator

mkruselj commented Aug 22, 2021 •
edited
Loading

Pics will be self-explanatory:

image

image

Seems to be UI only, DSP-wise it's fine.
@mkruselj mkruselj added UI Issues related to UI look&feel DSP Issues and feature requests related to sound generation in the synth Bug Report Item submitted using the Bug Report template labels Aug 22, 2021
@mkruselj mkruselj added this to the Surge XT 1.0 milestone Aug 22, 2021
mkruselj added a commit to mkruselj/surge that referenced this issue Aug 22, 2021
@mkruselj
Fix incorrect painting of global FX slot bypass states
7cb8be6 
Closes surge-synthesizer#4892


Also fixes the send 3/4 slider thumb colors in Dark skin.
@mkruselj mkruselj removed the DSP Issues and feature requests related to sound generation in the synth label Aug 22, 2021
mkruselj added a commit to mkruselj/surge that referenced this issue Aug 23, 2021
@mkruselj
Fix incorrect painting of global FX bypasses
b9d42bb 
Closes surge-synthesizer#4892

Also fixes color of send 3/4 sliders in Dark skin.
@mkruselj mkruselj mentioned this issue Aug 23, 2021
Merged
baconpaul added a commit that referenced this issue Aug 23, 2021
@mkruselj @baconpaul
Fix incorrect painting of global FX bypasses (#4893)
38bfe62 
* Fix incorrect painting of global FX bypasses

Closes #4892

Also fixes color of send 3/4 sliders in Dark skin.

* Small code review change

Co-authored-by: Paul Walker <[email protected]>
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template UI Issues related to UI look&feel
Projects
None yet
Milestone
Surge XT 1.0
Development

Successfully merging a pull request may close this issue.

Fix incorrect painting of global FX bypasses mkruselj/surge
1 participant
@mkruselj