Implement VST3 zoom #406
Merged
Implement VST3 zoom #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VST3 zoom is very similar to VST2 zoom since both rely on VSTGUI (and the associated bugs therein), but differ on the approach to notify the host. The primary difference in notifying the host is requiring a reference to the Steinberg::IPlugFrame frame class, which has to be publically exposed to allow the processor to see it. (This may be indicative of issues still with us choosing to not have a formal processor/editor split, as mentioned in surge-synthesizer#164). Regardless, once the IPlugFrame is exposed, we can use the resizeView() API in vst3 to inform hosts in our zoom callback, as implemented here.
baconpaul
force-pushed
the
zoom-vst3-take2-357
branch
from
dec0772 to
3d241b8
Compare
|
Thanks @kzantow. I’ll merge this in now and then we will have zoom on all our working combos!! Yay. And then to fix the rest of the zoom related issues... |
baconpaul
added a commit
to baconpaul/surge
that referenced
this pull request
Jul 10, 2019
VST3 zoom is very similar to VST2 zoom since both rely on VSTGUI (and the associated bugs therein), but differ on the approach to notify the host. The primary difference in notifying the host is requiring a reference to the Steinberg::IPlugFrame frame class, which has to be publically exposed to allow the processor to see it. (This may be indicative of issues still with us choosing to not have a formal processor/editor split, as mentioned in surge-synthesizer#164). Regardless, once the IPlugFrame is exposed, we can use the resizeView() API in vst3 to inform hosts in our zoom callback, as implemented here. Closes surge-synthesizer#357 Former-commit-id: 1c7fac21cbd6c1835b8f9fbefa8908dc154fd26e [formerly 8a7b5a7] Former-commit-id: 261ab8f8067137d2823d48074a3284cc8b8aa347 Former-commit-id: 368499d70341cbd99947f4fbd76c66bbc0d862bb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VST3 zoom is very similar to VST2 zoom since both rely on
VSTGUI (and the associated bugs therein), but differ on the approach
to notify the host. The primary difference in notifying the host
is requiring a reference to the Steinberg::IPlugFrame frame class,
which has to be publically exposed to allow the processor to see it.
(This may be indicative of issues still with us choosing to not have
a formal processor/editor split, as mentioned in #164). Regardless,
once the IPlugFrame is exposed, we can use the resizeView() API
in vst3 to inform hosts in our zoom callback, as implemented here.
Adresses issue #357