Handle out-of-range Patch.order #323
Merged
+74
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One patch - init - has a category and id which isn't in range. Others may. This results in +/_ browser sometimes going out of range on an array and segfaulting. So be defensive in our beyond-the-edge checkes. Addresses surge-synthesizer#319
|
I took a look at this and it seems to be OK now. Steps to attempt repro: Load up AU
|
baconpaul
added a commit
to baconpaul/surge
that referenced
this pull request
Jul 10, 2019
…ash-319 Handle out-of-range Patch.order Former-commit-id: df357958b49579768463270518cb2b479217563a [formerly cb73cff] Former-commit-id: 649c1a9f14b0300af5ec32a6fa6cea1cfaa8e59d Former-commit-id: c5058b9209709ffe404d32431c3e4ecb4d801e19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One patch - init - has a category and id which isn't in range. Others may.
This results in +/_ browser sometimes going out of range on
an array and segfaulting. So be defensive in our beyond-the-edge
checkes. Addresses #319