Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gui Crashes from "init" patch when pressing "category" - or + #319

Closed
sense-amr opened this issue Jan 17, 2019 · 4 comments
Closed

Gui Crashes from "init" patch when pressing "category" - or + #319

sense-amr opened this issue Jan 17, 2019 · 4 comments

Comments

@sense-amr
Copy link
Contributor

sense-amr commented Jan 17, 2019 •
edited
Loading

Gui Crashes from "init" patch when pressing "category" - or +
in latest build

image

Surge_categoryCrashGui.zip

  1. Load plugin on midi channel
  2. Open Gui
  3. init is selected ..
  4. Press category - or +
  5. Crash gui/Plugin Crash in host
  • OS: windows 10
  • Host Ableton Live, Bitwig,Fruity Loops

Video provided of crash in bitwig ..

image 2

Tested vst2 in Bitwig 1.3.16 /Ableton 9.7.4
Tested vst3 in Fruity Loops 20.0.1 Build 455

Note: In Bitwig 1.3.16 the plugin window and gui crashes only.. and can be re enabled from the plugin container..

In Ableton Live 9.7.4 the host crashes entirely.
In Fruity Loops 20.0.1 build 455 the host crashes entirely.
@sense-amr sense-amr changed the title Gui Crashes from "init" patch when pressing " Gui Crashes from "init" patch when pressing "cat" - or + Jan 17, 2019
@sense-amr sense-amr changed the title Gui Crashes from "init" patch when pressing "cat" - or + Gui Crashes from "init" patch when pressing "category" - or + Jan 17, 2019
@esaruoho esaruoho mentioned this issue Jan 17, 2019
Closed
@baconpaul
Copy link
Collaborator

Found the problem and have a fix coming.

@sense-amr
Copy link
Contributor Author

Excellent @baconpaul i'm glad to know it IS a legit problem .. :) cheers..

baconpaul added a commit to baconpaul/surge that referenced this issue Jan 17, 2019
@baconpaul
Handle out-of-range Patch.order
ba7f22c 
One patch - init - has a .order which isn't in range. Others may.
This results in +/_ browser sometimes going out of range on
an array and segfaulting. So be defensive in our beyond-the-edge
checkes. Addresses surge-synthesizer#319
@baconpaul baconpaul mentioned this issue Jan 17, 2019
Closed
@baconpaul
Copy link
Collaborator

Ok I found the edge case my fix didn’t fix and have a fix for that. But am away from computer now. Will do a pr and test this afternoon

baconpaul added a commit to baconpaul/surge that referenced this issue Jan 17, 2019
@baconpaul
Handle out-of-range Patch.order
01b0953 
One patch - init - has a category and id  which isn't in range. Others may.
This results in +/_ browser sometimes going out of range on
an array and segfaulting. So be defensive in our beyond-the-edge
checkes. Addresses surge-synthesizer#319
@baconpaul baconpaul mentioned this issue Jan 17, 2019
Merged
@baconpaul
Copy link
Collaborator

Thanks for testing @itsmedavep

baconpaul added a commit to baconpaul/surge that referenced this issue Jul 10, 2019
@baconpaul
Handle out-of-range Patch.order
316a0ac 
One patch - init - has a category and id  which isn't in range. Others may.
This results in +/_ browser sometimes going out of range on
an array and segfaulting. So be defensive in our beyond-the-edge
checkes. Addresses surge-synthesizer#319


Former-commit-id: b53297d1b6873ebbb0e116a07d595d0edc7103e4 [formerly 01b0953]
Former-commit-id: 09dcc967cb087993bcc0fcd4cc673449a6b88fe5
Former-commit-id: 0e4397049cebe38f429edb0539ed4c7e2abb1b21
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sense-amr @baconpaul