Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/1460 #3201

Merged
merged 3 commits into from
Nov 23, 2020
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/vst3/SurgeVst3Processor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -996,7 +996,7 @@ void SurgeVst3Processor::handleZoom(SurgeGUIEditor *e)
frame->setSize(newW, newH);
/*
** rather than calling setSize on myself as in vst2, I have to
** inform the plugin frame that I have resized wiht a reference
** inform the plugin frame that I have resized with a reference
** to a view (which is the editor). This collaborates with
** the host to resize once the content is scaled
*/
Expand All @@ -1007,12 +1007,13 @@ void SurgeVst3Processor::handleZoom(SurgeGUIEditor *e)
Steinberg::tresult res = ipf->resizeView(e, &vr);
if (res != Steinberg::kResultTrue)
{
std::ostringstream oss;
// Leaving this here for debug purposes. resizeView() can fail in non-fatal way and zoom reset is just too harsh.
/*std::ostringstream oss;
oss << "Your host failed to zoom VST3 to " << e->getZoomFactor() << " scale. "
<< "Surge will now attempt to reset the zoom level to 100%. You may see several "
<< "other error messages in the course of this being resolved.";
Surge::UserInteractions::promptError(oss.str(), "VST3 Host Zoom Error" );
e->setZoomFactor(100);
e->setZoomFactor(100);*/
mkruselj marked this conversation as resolved.
Show resolved Hide resolved
}
}

Expand Down