Bugfix/1460 #3201
Bugfix/1460 #3201
Conversation
| @@ -126,6 +130,12 @@ class SurgeGUIEditor : public EditorType, | |||
|
|
|||
| virtual Steinberg::tresult PLUGIN_API onSize(Steinberg::ViewRect* newSize) override; | |||
| virtual Steinberg::tresult PLUGIN_API checkSizeConstraint(Steinberg::ViewRect* newSize) override; | |||
| virtual Steinberg::tresult PLUGIN_API setContentScaleFactor(ScaleFactor factor) override | |||
| { | |||
| scaleFactor = factor; | |||
There was a problem hiding this comment.
It will be left for future refactoring to properly use this scaleFactor, if that's even possible. Now this is just used to resolve wrong GUI size from host on initial open vs. reopen. More info here: #1951
|
@Kingston1 tested on cubase Testing Checklist for @mkruselj and @baconpaul
|
|
OK mac shows the same behavior main vs your branch. |
|
From my tests this seems to behave just like main on mac and linux hosts. (Although main has bugs!) @mkruselj if you can confirm on windows daws I am happy for you to merge this! |
|
@baconpaul OK, did the test and there is no zoom dance in any of those hosts (plus some others that I have, like MuLab and Reason and FL20). However, it still happens that the attempted overly large zoom level is stored in DAW state. This needs to be updated when constraining the zoom level so that it doesn't pop that "zoom level too large" error when opening the project (which currently happens in Studio One and Live, even if plugin window is not opened). For now I will merge this, though. Thank you for the awesome fix, @Kingston1! |
No description provided.