Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement retrigger properly for all oscillator types #3178

Closed
wants to merge 3 commits into from
Closed

Implement retrigger properly for all oscillator types #3178

wants to merge 3 commits into from

Conversation

mkruselj
Copy link
Collaborator

Closes #3171

@mkruselj
Copy link
Collaborator Author

mkruselj commented Nov 19, 2020

Questions for @baconpaul:

  1. Should we add a very tiny quick fade-in for sine/FM2/FM3/window? It seems that WT osc has something that de-clicks its output even with retrigger off, so maybe others should match that?
  2. Method to somehow set osc retrigger from the config.xml presets. Window, Sine, FM2/FM3 and WT should have it on by default when selecting osc type.

EDIT: After further thought, I've decided that 2. is not important. Let the users click the button...

@mkruselj mkruselj changed the title Implement retrigger properly for all oscillator types 1.9 MERGEABLE - Implement retrigger properly for all oscillator types Jan 21, 2021
@mkruselj mkruselj changed the title 1.9 MERGEABLE - Implement retrigger properly for all oscillator types 1.8.2 MERGEABLE - Implement retrigger properly for all oscillator types Jan 27, 2021
@mkruselj mkruselj changed the title 1.8.2 MERGEABLE - Implement retrigger properly for all oscillator types Implement retrigger properly for all oscillator types Feb 1, 2021
@mkruselj
Copy link
Collaborator Author

mkruselj commented Feb 1, 2021

Since clang-format did its thing to the codebase, and FM3 had some work done by @baconpaul which clashed with this PR, I am closing this one in favor of #3785 which is done from scratch.

@mkruselj mkruselj closed this Feb 1, 2021
@mkruselj mkruselj deleted the key-retrigger-for-all-osctypes branch February 1, 2021 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Oscillator Retrigger is not implemented for a number of oscillators
1 participant