Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oscillator Retrigger is not implemented for a number of oscillators #3171

Closed
mkruselj opened this issue Nov 18, 2020 · 1 comment · Fixed by #3785
Closed

Oscillator Retrigger is not implemented for a number of oscillators #3171

mkruselj opened this issue Nov 18, 2020 · 1 comment · Fixed by #3785
Assignees
Labels
Bug Report Item submitted using the Bug Report template DSP Issues and feature requests related to sound generation in the synth Oscillator Features or additions to the oscillator section
Milestone

Comments

@mkruselj
Copy link
Collaborator

mkruselj commented Nov 18, 2020

As it stands currently (before 1.8 release), oscillator retrigger parameter is only valid in Classic, Wavetable and S&H Noise oscillator types. All other oscillators are blissfully unaware of this parameter and will always retrigger from 0° on every new note played.

For 1.9, "the oscillator release", enable this parameter for all oscillator types, and handle streaming so that old patches using the affected oscillator types are loaded with Retrigger button enabled, if it wasn't.

@mkruselj mkruselj added DSP Issues and feature requests related to sound generation in the synth Oscillator Features or additions to the oscillator section Bug Report Item submitted using the Bug Report template labels Nov 18, 2020
@mkruselj mkruselj added this to the 1.9.0 milestone Nov 18, 2020
@mkruselj mkruselj changed the title Oscillator Retrigger is not implemented for many oscillators Oscillator Retrigger is not implemented for a number of oscillators Nov 19, 2020
@mkruselj
Copy link
Collaborator Author

mkruselj commented Nov 19, 2020

Actually, retrigger is implemented for Window, but curiously only if there's more than 1 unison voice selected. This is unexpected behavior in my book. Sine, FM2 and FM3 literally don't have it implemented. It's actually commented out in FM2/FM3, heh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Report Item submitted using the Bug Report template DSP Issues and feature requests related to sound generation in the synth Oscillator Features or additions to the oscillator section
Projects
None yet
1 participant