Set ringout for Reverb2 #1690
Merged
Set ringout for Reverb2 #1690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we go around restoring Reverb2, the ringout parameter was uninitialized leading to a clean 0 on mac (infinite ringout) but a random value on windows (random ringout). Set it to a reasonable approximation of the right time. Closes surge-synthesizer#1689 Addresses surge-synthesizer#881
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we go around restoring Reverb2, the ringout parameter was
uninitialized leading to a clean 0 on mac (infinite ringout)
but a random value on windows (random ringout). Set it to
a reasonable approximation of the right time.
Closes #1689
Addresses #881