Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverb2 Pre-Delay is unimplemented #1689

Closed
baconpaul opened this issue Apr 9, 2020 · 0 comments · Fixed by #1690
Closed

Reverb2 Pre-Delay is unimplemented #1689

baconpaul opened this issue Apr 9, 2020 · 0 comments · Fixed by #1690

Comments

@baconpaul
Copy link
Collaborator

baconpaul commented Apr 9, 2020 •
edited
Loading

like it is just ignored
baconpaul added a commit to baconpaul/surge that referenced this issue Apr 9, 2020
@baconpaul
Set ringout for Reverb2
661585a 
As we go around restoring Reverb2, the ringout parameter was
uninitialized leading to a clean 0 on mac (infinite ringout)
but a random value on windows (random ringout). Set it to
a reasonable approximation of the right time.

Closes surge-synthesizer#1689
Addresses surge-synthesizer#881
@baconpaul baconpaul mentioned this issue Apr 9, 2020
Merged
baconpaul added a commit that referenced this issue Apr 9, 2020
@baconpaul
Set ringout for Reverb2 (#1690)
da8f575 
As we go around restoring Reverb2, the ringout parameter was
uninitialized leading to a clean 0 on mac (infinite ringout)
but a random value on windows (random ringout). Set it to
a reasonable approximation of the right time.

Closes #1689
Addresses #881
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set ringout for Reverb2 baconpaul/surge
1 participant
@baconpaul