Re-factor the keysplit code; remove crash #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The helper I introduced to handle KeySplit UI changing was both wrong and unnecessary. So remove it, thereby killing a crash and also making the code ready to finish the split mode. Addresses surge-synthesizer#1413 Closes surge-synthesizer#1425
baconpaul
force-pushed
the
lfo-copy-crash-1425
branch
from
173a798 to
77e761b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The helper I introduced to handle KeySplit UI changing was
both wrong and unnecessary. So remove it, thereby killing a crash
and also making the code ready to finish the split mode.
Addresses #1413
Closes #1425