Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FL Studio crashes when copying LFOs two times #1425

Closed
VincyZed opened this issue Dec 17, 2019 · 4 comments · Fixed by #1426
Closed

FL Studio crashes when copying LFOs two times #1425

VincyZed opened this issue Dec 17, 2019 · 4 comments · Fixed by #1426

Comments

@VincyZed
Copy link
Collaborator

Describe the bug
FL Studio crashes (simply closes unexpectedly without any error message) when doing the following:

To Reproduce
Steps to reproduce the behavior:

  1. Open Surge.
  2. Copy any LFO once.
  3. Copy any LFO a second time.
  4. FL Studio crashes.

Surge version
NIGHTLY-2019-12-16-aa75776
VST3 x64

Desktop config:

  • OS: Windows 10 x64
  • Host: FL Studio 20.6 x64

Additional context
Weird crash that probably only happens since recently. Tested in 1.6.4.1 VST3 in the same environment and it works fine (the crash does not occur).
@baconpaul
Copy link
Collaborator

I didn’t even know you could copy an LFO! Will look.

@baconpaul baconpaul added this to the 1.6.5 milestone Dec 17, 2019
@baconpaul
Copy link
Collaborator

Oh yeah I introduced this in the nightly with a half-completed thing which I realized I don't need anyway. Will fix this morning. Thanks!

baconpaul added a commit to baconpaul/surge that referenced this issue Dec 17, 2019
@baconpaul
Re-factor the keysplit code; remove crash
173a798 
The helper I introduced to handle KeySplit UI changing was
both wrong and unnecessary. So remove it, thereby killing a crash
and also making the code ready to finish the split mode.

Addresses surge-synthesizer#1413
Closes surge-synthesizer#1425
@VincyZed
Copy link
Collaborator Author

Awesome. Thanks! :)

@baconpaul baconpaul mentioned this issue Dec 17, 2019
Merged
@baconpaul
Copy link
Collaborator

Yeah refactored that half finished code to (1) be less clumsy and (2) not crash anymore. Pull request in now. Should be in the nightly in an hour or so. Thanks - great catch!

baconpaul added a commit to baconpaul/surge that referenced this issue Dec 17, 2019
@baconpaul
Re-factor the keysplit code; remove crash
77e761b 
The helper I introduced to handle KeySplit UI changing was
both wrong and unnecessary. So remove it, thereby killing a crash
and also making the code ready to finish the split mode.

Addresses surge-synthesizer#1413
Closes surge-synthesizer#1425
baconpaul added a commit that referenced this issue Dec 17, 2019
@baconpaul
Re-factor the keysplit code; remove crash (#1426)
53362df 
The helper I introduced to handle KeySplit UI changing was
both wrong and unnecessary. So remove it, thereby killing a crash
and also making the code ready to finish the split mode.

Addresses #1413
Closes #1425
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re-factor the keysplit code; remove crash baconpaul/surge
2 participants
@baconpaul @VincyZed