Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Envelope Modulation can't increase sustain #825

Closed
baconpaul opened this issue Apr 10, 2019 · 0 comments · Fixed by #1458
Closed

Envelope Modulation can't increase sustain #825

baconpaul opened this issue Apr 10, 2019 · 0 comments · Fixed by #1458
Labels
Feature Request New feature request

Comments

@baconpaul
Copy link
Collaborator

As reported by TJ Shredder on KVR. Modulating the sustain of an envelope can decrease it but can't increase it; so you can't swell a sustain with a modulator.

I haven't confirmed this yet - that's step one - but clearly this is something you should be able to do.
@baconpaul baconpaul added the Feature Request New feature request label Apr 10, 2019
@baconpaul baconpaul added this to the 1.6.n milestone Apr 10, 2019
@baconpaul baconpaul modified the milestones: 1.6.n, 1.6.2 Jun 16, 2019
@baconpaul baconpaul modified the milestones: 1.6.2, 1.6.3 Aug 17, 2019
@baconpaul baconpaul mentioned this issue Dec 20, 2019
Closed
baconpaul added a commit to baconpaul/surge that referenced this issue Jan 8, 2020
@baconpaul
Fixed to ADSR Analog Mode
1ba7676 
ADSR analog mode had two bugs

1. It misused _mm_and_ps so was incorrectly rounding decay time
2. It didn't allow for swells in sustain once the sustain stage
   was underway

This fixes both those problems. In some cases the fix to surge-synthesizer#1 will
change the sound of patches by making the decay time slower (but
more correct).

Closes surge-synthesizer#1439
Closes surge-synthesizer#825
@baconpaul baconpaul mentioned this issue Jan 8, 2020
Merged
baconpaul added a commit to baconpaul/surge that referenced this issue Jan 8, 2020
@baconpaul
Fixed to ADSR Analog Mode
dd57542 
ADSR analog mode had two bugs

1. It misused _mm_and_ps so was incorrectly rounding decay time
2. It didn't allow for swells in sustain once the sustain stage
   was underway

This fixes both those problems. In some cases the fix to surge-synthesizer#1 will
change the sound of patches by making the decay time slower (but
more correct).

Closes surge-synthesizer#1439
Closes surge-synthesizer#825
baconpaul added a commit to baconpaul/surge that referenced this issue Jan 8, 2020
@baconpaul
Fixed to ADSR Analog Mode
eaafe5b 
ADSR analog mode had two bugs

1. It misused _mm_and_ps so was incorrectly rounding decay time
2. It didn't allow for swells in sustain once the sustain stage
   was underway

This fixes both those problems. In some cases the fix to surge-synthesizer#1 will
change the sound of patches by making the decay time slower (but
more correct).

Closes surge-synthesizer#1439
Closes surge-synthesizer#825
baconpaul added a commit that referenced this issue Jan 8, 2020
@baconpaul
Fixed to ADSR Analog Mode (#1458)
ea2b0fd 
ADSR analog mode had two bugs

1. It misused _mm_and_ps so was incorrectly rounding decay time
2. It didn't allow for swells in sustain once the sustain stage
   was underway

This fixes both those problems. In some cases the fix to #1 will
change the sound of patches by making the decay time slower (but
more correct).

Closes #1439
Closes #825
@mkruselj mkruselj removed this from the Currently Unscheduled milestone Jun 18, 2020
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request New feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed to ADSR Analog Mode baconpaul/surge
2 participants
@mkruselj @baconpaul