Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching patches doesn't refresh the display on the VST3 version #1

Closed
kurasu opened this issue Sep 21, 2018 · 0 comments
Closed

Switching patches doesn't refresh the display on the VST3 version #1

kurasu opened this issue Sep 21, 2018 · 0 comments

Comments

@kurasu
Copy link
Collaborator

kurasu commented Sep 21, 2018

No description provided.

@kurasu kurasu closed this as completed in 7810802 Sep 24, 2018
baconpaul pushed a commit to baconpaul/surge that referenced this issue Jul 10, 2019
baconpaul pushed a commit to baconpaul/surge that referenced this issue Jul 10, 2019
updating from kurasu

Former-commit-id: 7de625c
baconpaul added a commit to baconpaul/surge that referenced this issue Jan 8, 2020
ADSR analog mode had two bugs

1. It misused _mm_and_ps so was incorrectly rounding decay time
2. It didn't allow for swells in sustain once the sustain stage
   was underway

This fixes both those problems. In some cases the fix to surge-synthesizer#1 will
change the sound of patches by making the decay time slower (but
more correct).

Closes surge-synthesizer#1439
Closes surge-synthesizer#825
baconpaul added a commit to baconpaul/surge that referenced this issue Jan 8, 2020
ADSR analog mode had two bugs

1. It misused _mm_and_ps so was incorrectly rounding decay time
2. It didn't allow for swells in sustain once the sustain stage
   was underway

This fixes both those problems. In some cases the fix to surge-synthesizer#1 will
change the sound of patches by making the decay time slower (but
more correct).

Closes surge-synthesizer#1439
Closes surge-synthesizer#825
baconpaul added a commit to baconpaul/surge that referenced this issue Jan 8, 2020
ADSR analog mode had two bugs

1. It misused _mm_and_ps so was incorrectly rounding decay time
2. It didn't allow for swells in sustain once the sustain stage
   was underway

This fixes both those problems. In some cases the fix to surge-synthesizer#1 will
change the sound of patches by making the decay time slower (but
more correct).

Closes surge-synthesizer#1439
Closes surge-synthesizer#825
baconpaul added a commit that referenced this issue Jan 8, 2020
ADSR analog mode had two bugs

1. It misused _mm_and_ps so was incorrectly rounding decay time
2. It didn't allow for swells in sustain once the sustain stage
   was underway

This fixes both those problems. In some cases the fix to #1 will
change the sound of patches by making the decay time slower (but
more correct).

Closes #1439
Closes #825
@ThyHG ThyHG mentioned this issue Sep 2, 2020
baconpaul pushed a commit to baconpaul/surge that referenced this issue Sep 30, 2020
baconpaul pushed a commit to baconpaul/surge that referenced this issue May 24, 2023
add commits with sst effects interface changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant