Oscilloscope: Final 1.2 signoff

[baconpaul]

@mx and @mkruselj - what's needed on the scope for us to ship a 1.2?

[mkruselj]

Ah I should do some UI work on the overlay...

[mx]

On my end nothing. I might add a high-definition variable-frequency mode since the CQT didn't work out but that's not necessary to ship.

[baconpaul]

Cool
Are we actually using pffft in the codebase right now by the way? If not I may turn off the sub-build before I ship 1.2 then turn it on again after (but will see!)

[baconpaul]

Things I noticed

1. Tearout at zoom needs a resize
2. The scope doesn't remember waveform vs spectrum setting when saved and open/closed
3. on macOS when torn in the controls dont' appear
4. the controls aren't in a colored backdrop like mseg, formula, etc

[baconpaul]

The controls not appearing is only in spectrum view. I think the spectrum view should grow to fill since there's no control

Also we should probably draw the spectrum gradient filled like everything else.

[mx]

The plan is to eventually add some controls (I have some prototype ones that don't do anything) which is why I haven't expanded it to fill yet.

…

On Tue, Jan 24, 2023, 9:28 PM Paul ***@***.***> wrote: [image: Screen Shot 2023-01-24 at 9 27 43 PM] <https://user-images.githubusercontent.com/13387561/214467068-cbead3d4-bbbd-4e6b-b325-be5325188dbe.png> The controls not appearing is only in spectrum view. I think the spectrum view should grow to fill since there's no control Also we should probably draw the spectrum gradient filled like everything else. — Reply to this email directly, view it on GitHub <#6778 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACJPYJOAM3RCG5QJRWLSNUDWUCFVZANCNFSM6AAAAAATU2YZ44> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[mkruselj]

Dooooooneeeeeeee #6903!

...except maybe we want right-click context menu entries to point to manual?

[baconpaul]

Do we have manual entries for the scope yet? Its pretty easy to add to the paramdocumentation.xml if there's a target.

[mkruselj]

I have added #level-meter to paramdocumentation.xml (for the ? menu entry in level meter's right-click context menu), but yeah we should indeed add right-click menus to all scope parameters just like MSEG editor has, too...

[Andreya-Autumn]

...and with surge-synthesizer/surge-synthesizer.github.io#302 I have now given it a place to land in the manual. So I do believe we're finally ready. :)

[Andreya-Autumn]

ED counters: "If you use RMB menus on trigger mode or scope mode it changed value but doesn't update GUI", so re-opening.

[Andreya-Autumn]

...which is adressed by #6921, so closing again. :)