Scope RMB on Trigger Type resets value (#6921)

Make sure to send value changed to the correct boject. Addresses #6778
surge-synthesizer · Apr 9, 2023 · f762fba · f762fba
1 parent 9248675
commit f762fba
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/src/surge-xt/gui/overlays/Oscilloscope.cpp b/src/surge-xt/gui/overlays/Oscilloscope.cpp
@@ -717,7 +717,14 @@ int32_t Oscilloscope::controlModifierClicked(Surge::GUI::IComponentTagValue *pCo
             contextMenu.addItem(op.first, true, (val == pControl->getValue()),
                                 [val, pControl, this]() {
                                     pControl->setValue(val);
-                                    valueChanged(pControl);
+
+                                    // The switch button is self-draw and has its own value change
+                                    // so we need to handle that eventuality here
+                                    auto sc = dynamic_cast<SwitchButton *>(pControl);
+                                    if (sc)
+                                        sc->valueChanged(pControl);
+                                    else
+                                        valueChanged(pControl);
 
                                     auto iv = pControl->asJuceComponent();