Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSEG open close tear out is a bit messy #5512

Closed
baconpaul opened this issue Nov 26, 2021 · 3 comments · Fixed by #5513
Closed

MSEG open close tear out is a bit messy #5512

baconpaul opened this issue Nov 26, 2021 · 3 comments · Fixed by #5513
Labels
Code Refactoring General code refactoring and cleanup issues like names, unused variables, warnings, fixme
Milestone
Surge XT 1.x

Comments

@baconpaul
Copy link
Collaborator

Clean this all up after XT1
@baconpaul baconpaul added the Feature Request New feature request label Nov 26, 2021
@baconpaul baconpaul added this to the After Surge XT 1.0 milestone Nov 26, 2021
baconpaul added a commit to baconpaul/surge that referenced this issue Nov 26, 2021
@baconpaul
MSEG TearOut on Preset Change doesn't re-dock
beadae7 
Closes surge-synthesizer#5512
@baconpaul baconpaul mentioned this issue Nov 26, 2021
Merged
@mkruselj mkruselj added Code Refactoring General code refactoring and cleanup issues like names, unused variables, warnings, fixme and removed Feature Request New feature request labels Nov 26, 2021
mkruselj pushed a commit that referenced this issue Nov 26, 2021
@baconpaul
MSEG TearOut on Preset Change doesn't re-dock (#5513)
d45997a 
Closes #5512
@baconpaul baconpaul reopened this Nov 27, 2021
@baconpaul baconpaul mentioned this issue Nov 27, 2021
Closed
@baconpaul
Copy link
Collaborator Author

i'm gonna bump this out of the milestone. and may even close it when we get around to xt2

@baconpaul baconpaul modified the milestones: Surge XT 1.1, Surge XT 2.0 Apr 5, 2022
@mkruselj mkruselj modified the milestones: Surge XT 2.0, Surge XT 1.1.x Aug 21, 2022
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
@mkruselj
Copy link
Collaborator

mkruselj commented May 8, 2024 •
edited
Loading

@baconpaul Can we say this one is not worth doing at all for 1.x and everything is better anyways in XT2/SCXT realm? So close.

@baconpaul
Copy link
Collaborator Author

Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Code Refactoring General code refactoring and cleanup issues like names, unused variables, warnings, fixme
Projects
None yet
Milestone
Surge XT 1.x
Development

Successfully merging a pull request may close this issue.

MSEG TearOut on Preset Change doesn't re-dock baconpaul/surge
2 participants
@mkruselj @baconpaul