Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overlays don't stay fronted on skin refresh #5445

Closed
mkruselj opened this issue Nov 22, 2021 · 4 comments · Fixed by #5515 or #5551
Closed

Overlays don't stay fronted on skin refresh #5445

mkruselj opened this issue Nov 22, 2021 · 4 comments · Fixed by #5515 or #5551
Labels
Bug Report Item submitted using the Bug Report template UI Issues related to UI look&feel
Milestone
Surge XT 1.0

Comments

@mkruselj
Copy link
Collaborator

As below:

image

image
@mkruselj mkruselj added UI Issues related to UI look&feel Bug Report Item submitted using the Bug Report template labels Nov 22, 2021
@mkruselj mkruselj added this to the Surge XT 1.0 milestone Nov 22, 2021
baconpaul added a commit to baconpaul/surge that referenced this issue Nov 27, 2021
@baconpaul
Correct front overlays
85eea9f 
1. Keep them fronted on rebuilds and skin changes
2. Allow click-menu-bar to bring-to-front for two overlay case

Closes surge-synthesizer#5445
@baconpaul baconpaul mentioned this issue Nov 27, 2021
Merged
baconpaul added a commit that referenced this issue Nov 27, 2021
@baconpaul
Correct front overlays (#5515)
619d095 
1. Keep them fronted on rebuilds and skin changes
2. Allow click-menu-bar to bring-to-front for two overlay case

Closes #5445
@mkruselj
Copy link
Collaborator Author

Reopening for one edge case:

  1. Open MSEG editor
  2. Click patch save button
  3. F5 to refresh skin

Result: MSEG goes in front of patch save (which is supposedly modal)

Expected: patch save is modal so should be always on top.

Miniedit is also modal but they autoclose on skin refresh so we need not worry about them. But patch save should be always on top.

@mkruselj mkruselj reopened this Nov 27, 2021
@baconpaul
Copy link
Collaborator

yeah that one may be hard to fix. the z-order on skin refresh is lost

@baconpaul
Copy link
Collaborator

this is all related to #5512 basically
the mseg/formula is 'special' in an annoying way and i want to make it non special and the skin refresh actually replaces components.
this edge case may bounce out of the xt milestone basically

(note as of last night you can change Z order by clicking on a title bar)

@mkruselj mkruselj added the Might Bounce Out Of Milestone Issues we think might not make it for official release, coming from the milestone we're working on label Nov 27, 2021
@baconpaul
Copy link
Collaborator

Managed to fix this extreme edge case in XT1. When you press F5 with a patch over the mseg, the mseg blinks through (fixing that required #5512) but then the modal overlay re-fronts. Will merge that and close this issue and the blink through will get fixed when #5512 gets done

baconpaul added a commit to baconpaul/surge that referenced this issue Dec 4, 2021
@baconpaul
ZOrder Edge Case with Modal Overlays fixed
0bd966e 
If you F5 skin refresh with a patch dialog over an mseg
the mseg would front. Now the mseg blinks momentarily but
thepatch store stays fronted

CLoses surge-synthesizer#5445
@baconpaul baconpaul mentioned this issue Dec 4, 2021
Merged
baconpaul added a commit that referenced this issue Dec 4, 2021
@baconpaul
ZOrder Edge Case with Modal Overlays fixed (#5551)
e789386 
If you F5 skin refresh with a patch dialog over an mseg
the mseg would front. Now the mseg blinks momentarily but
thepatch store stays fronted

CLoses #5445
@mkruselj mkruselj removed the Might Bounce Out Of Milestone Issues we think might not make it for official release, coming from the milestone we're working on label Apr 29, 2022
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template UI Issues related to UI look&feel
Projects
None yet
Milestone
Surge XT 1.0
2 participants
@mkruselj @baconpaul