Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabled tune button flashes when FX presets are cycled #5459

Closed
mthierman opened this issue Nov 23, 2021 · 0 comments · Fixed by #5460
Closed

Enabled tune button flashes when FX presets are cycled #5459

mthierman opened this issue Nov 23, 2021 · 0 comments · Fixed by #5460
Labels
Bug Report Item submitted using the Bug Report template

Comments

@mthierman
Copy link
Contributor

mthierman commented Nov 23, 2021 •
edited
Loading

Bug Description:
Tune button flashes when changing FX presets

Surge Version
Version: Surge XT 0.99.nightly.6df105b
Build: 2021-11-23 @ 22:32:34 on 'fv-az30-359/pipeline' with 'MSVC-19.29.30137.0' using JUCE 6.1.2
System: Windows 64-bit Standalone on Intel(R) Core(TM) i5-9400F CPU @ 2.90GHz
Sample Rate: 48.0 kHz

  • Plugin Type: VST3
  • Bitness: 64 bit

Reproduction Steps:
Steps to reproduce the behavior:

  1. Enable tuning
  2. Cycle through FX presets

Expected Behavior:
Tune button should not flash when cycling presets

Screenshots:
tuneflash

Computer Information (please complete the following information):

  • OS: Windows 11
  • Host: Reaper
  • Version: 6.41
@mthierman mthierman added the Bug Report Item submitted using the Bug Report template label Nov 23, 2021
baconpaul added a commit to baconpaul/surge that referenced this issue Nov 24, 2021
@baconpaul
A collection of beta fixes
8d94c2e 
1. Tune button blinks because it uses legacy state from toggle.
   Closes surge-synthesizer#5459
2. Allow drag outside of SS to reset values. Closes surge-synthesizer#5455
3. Use JUCE documetn buttons on overlay popout/close. Closes surge-synthesizer#5453
@baconpaul baconpaul mentioned this issue Nov 24, 2021
Merged
baconpaul added a commit that referenced this issue Nov 24, 2021
@baconpaul
A collection of beta fixes (#5460)
6f95a0f 
1. Tune button blinks because it uses legacy state from toggle.
   Closes #5459
2. Allow drag outside of SS to reset values. Closes #5455
3. Use JUCE documetn buttons on overlay popout/close. Closes #5453
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

A collection of beta fixes baconpaul/surge
1 participant
@mthierman