Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the overlay tear/close buttons match maximize/close buttons from standalone #5453

Closed
mkruselj opened this issue Nov 23, 2021 · 0 comments · Fixed by #5460
Closed

Make the overlay tear/close buttons match maximize/close buttons from standalone #5453

mkruselj opened this issue Nov 23, 2021 · 0 comments · Fixed by #5460
Labels
Feature Request New feature request UI Issues related to UI look&feel
Milestone
Surge XT 1.0

Comments

@mkruselj
Copy link
Collaborator

mkruselj commented Nov 23, 2021 •
edited
Loading

image

Because it would look nicer. And because we replaced other vanilla JUCE buttons already. And it Just Makes Sense. 🙂
@mkruselj mkruselj added Feature Request New feature request UI Issues related to UI look&feel labels Nov 23, 2021
@mkruselj mkruselj added this to the Surge XT 1.0 milestone Nov 23, 2021
baconpaul added a commit to baconpaul/surge that referenced this issue Nov 24, 2021
@baconpaul
A collection of beta fixes
8d94c2e 
1. Tune button blinks because it uses legacy state from toggle.
   Closes surge-synthesizer#5459
2. Allow drag outside of SS to reset values. Closes surge-synthesizer#5455
3. Use JUCE documetn buttons on overlay popout/close. Closes surge-synthesizer#5453
@baconpaul baconpaul mentioned this issue Nov 24, 2021
Merged
baconpaul added a commit that referenced this issue Nov 24, 2021
@baconpaul
A collection of beta fixes (#5460)
6f95a0f 
1. Tune button blinks because it uses legacy state from toggle.
   Closes #5459
2. Allow drag outside of SS to reset values. Closes #5455
3. Use JUCE documetn buttons on overlay popout/close. Closes #5453
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request New feature request UI Issues related to UI look&feel
Projects
None yet
Milestone
Surge XT 1.0
Development

Successfully merging a pull request may close this issue.

A collection of beta fixes baconpaul/surge
1 participant
@mkruselj