Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JUCE has corrected their mouseExit modal bug; adapt. #5318

Closed
baconpaul opened this issue Oct 28, 2021 · 3 comments · Fixed by #6021
Closed

JUCE has corrected their mouseExit modal bug; adapt. #5318

baconpaul opened this issue Oct 28, 2021 · 3 comments · Fixed by #6021
Labels
Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Milestone

Comments

@baconpaul
Copy link
Collaborator

https://forum.juce.com/t/popupmenu-and-mouseexit/46822/5

@baconpaul baconpaul added this to the Surge XT 1.0 milestone Oct 28, 2021
@mkruselj mkruselj added Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. labels Oct 28, 2021
@baconpaul baconpaul added the Might Bounce Out Of Milestone Issues we think might not make it for official release, coming from the milestone we're working on label Nov 11, 2021
@baconpaul
Copy link
Collaborator Author

I think the way to adapt in XT1 is to "not merge this change into our juce fork" and ship with juce where we have it
The correct change is to remove all the random endHovers and add a hoverable interface which has an 'upHover' and 'downHover' and so on for a counter.

But i'm gonna bump this out of XT milestone and just remember to leave our juce build where it is.

@mkruselj mkruselj removed the Might Bounce Out Of Milestone Issues we think might not make it for official release, coming from the milestone we're working on label Nov 20, 2021
baconpaul added a commit to baconpaul/surge that referenced this issue Apr 5, 2022
Juce fixed a bug where menu launch didn't exit a complent
but that screwed up our hover management. Start fixing it.

Addresses surge-synthesizer#5318
@baconpaul
Copy link
Collaborator Author

OK @mkruselj once I merge the above slider and multi switch should work

The trick is i've added a state to the base class which we increment and decrement properly. So the only change that should be needed is

in every widgets startHover add

  if (incrementHover() > 1)
        return;

and in every widgets endHover add

    if (decrementHover() != 0)
        return;

but then we have to test them all.

My theory is if we do that everywhere with the version I pushed, everything will work, and you can merge it and close this issue. Second best would be to do that everywhere, merge it, and add a checklist of things which didnt work to this issue and i can wrap it up. Third best is I am wrong and this doesn't fix anything other than the two cases i tried in which case, back to the drawing board!

baconpaul added a commit that referenced this issue Apr 5, 2022
Juce fixed a bug where menu launch didn't exit a complent
but that screwed up our hover management. Start fixing it.

Addresses #5318
mkruselj added a commit to mkruselj/surge that referenced this issue Apr 5, 2022
baconpaul added a commit to baconpaul/surge that referenced this issue Apr 5, 2022
Stuck hover is way easier with a bool which is just set in the
menu handler. This accomplishes that and also fixes slider,
multiswitch, switch, and mod button

Addresses surge-synthesizer#5318
baconpaul added a commit to baconpaul/surge that referenced this issue Apr 5, 2022
Stuck hover is way easier with a bool which is just set in the
menu handler. This accomplishes that and also fixes slider,
multiswitch, switch, and mod button

Addresses surge-synthesizer#5318
mkruselj pushed a commit that referenced this issue Apr 5, 2022
Stuck hover is way easier with a bool which is just set in the
menu handler. This accomplishes that and also fixes slider,
multiswitch, switch, and mod button

Addresses #5318
mkruselj added a commit to mkruselj/surge that referenced this issue Apr 5, 2022
@mkruselj
Copy link
Collaborator

mkruselj commented Apr 5, 2022

Things left after PR #6019:

  • LFO type
  • LFO edit pencil
  • Buttons in MSEG Editor
  • Buttons in Formula Editor
  • For some reason osc type menu doesn't work (hover disappears on RMB) but FX menu does work, and they have exact same code...

baconpaul pushed a commit that referenced this issue Apr 5, 2022
baconpaul added a commit to baconpaul/surge that referenced this issue Apr 5, 2022
Clean up the tricky bits and bobs

Closes surge-synthesizer#5318
mkruselj pushed a commit that referenced this issue Apr 5, 2022
Clean up the tricky bits and bobs

Closes #5318
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants