-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JUCE has corrected their mouseExit modal bug; adapt. #5318
Comments
I think the way to adapt in XT1 is to "not merge this change into our juce fork" and ship with juce where we have it But i'm gonna bump this out of XT milestone and just remember to leave our juce build where it is. |
Juce fixed a bug where menu launch didn't exit a complent but that screwed up our hover management. Start fixing it. Addresses surge-synthesizer#5318
OK @mkruselj once I merge the above slider and multi switch should work The trick is i've added a state to the base class which we increment and decrement properly. So the only change that should be needed is in every widgets startHover add if (incrementHover() > 1)
return; and in every widgets endHover add if (decrementHover() != 0)
return; but then we have to test them all. My theory is if we do that everywhere with the version I pushed, everything will work, and you can merge it and close this issue. Second best would be to do that everywhere, merge it, and add a checklist of things which didnt work to this issue and i can wrap it up. Third best is I am wrong and this doesn't fix anything other than the two cases i tried in which case, back to the drawing board! |
Juce fixed a bug where menu launch didn't exit a complent but that screwed up our hover management. Start fixing it. Addresses #5318
Addresses surge-synthesizer#5318
Stuck hover is way easier with a bool which is just set in the menu handler. This accomplishes that and also fixes slider, multiswitch, switch, and mod button Addresses surge-synthesizer#5318
Stuck hover is way easier with a bool which is just set in the menu handler. This accomplishes that and also fixes slider, multiswitch, switch, and mod button Addresses surge-synthesizer#5318
Stuck hover is way easier with a bool which is just set in the menu handler. This accomplishes that and also fixes slider, multiswitch, switch, and mod button Addresses #5318
Things left after PR #6019:
|
Clean up the tricky bits and bobs Closes surge-synthesizer#5318
Clean up the tricky bits and bobs Closes #5318
https://forum.juce.com/t/popupmenu-and-mouseexit/46822/5
The text was updated successfully, but these errors were encountered: