Last Hover Change (#6021)

Clean up the tricky bits and bobs Closes #5318
surge-synthesizer · Apr 5, 2022 · af49350 · af49350
1 parent 4d6a25c
commit af49350
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 7 deletions.
diff --git a/src/surge-xt/gui/SurgeGUIEditorValueCallbacks.cpp b/src/surge-xt/gui/SurgeGUIEditorValueCallbacks.cpp
@@ -631,8 +631,18 @@ int32_t SurgeGUIEditor::controlModifierClicked(Surge::GUI::IComponentTagValue *c
     {
         if (lfoDisplay->isMSEG() || lfoDisplay->isFormula())
         {
-            auto tag = lfoDisplay->isMSEG() ? MSEG_EDITOR : FORMULA_EDITOR;
-            lfoDisplay->showLFODisplayPopupMenu(tag);
+            std::string olname = lfoDisplay->isMSEG() ? "MSEG Editor" : "Formula Editor";
+            std::string helpname = lfoDisplay->isMSEG() ? "mseg-editor" : "formula-editor";
+
+            auto msurl = SurgeGUIEditor::helpURLForSpecial(&(synth->storage), helpname);
+            auto hurl = SurgeGUIEditor::fullyResolvedHelpURL(msurl);
+
+            auto hmen = std::make_unique<Surge::Widgets::MenuTitleHelpComponent>(olname, hurl);
+            hmen->setSkin(currentSkin, bitmapStore);
+            auto contextMenu = juce::PopupMenu();
+            contextMenu.addCustomItem(-1, std::move(hmen));
+            contextMenu.showMenuAsync(popupMenuOptions(control->asJuceComponent(), false),
+                                      Surge::GUI::makeEndHoverCallback(control));
         }
     }
 

diff --git a/src/surge-xt/gui/overlays/LuaEditors.cpp b/src/surge-xt/gui/overlays/LuaEditors.cpp
@@ -494,7 +494,8 @@ struct FormulaControlArea : public juce::Component,
 
             editor->addHelpHeaderTo("Formula Editor", hurl, contextMenu);
 
-            contextMenu.showMenuAsync(editor->popupMenuOptions(this, false));
+            contextMenu.showMenuAsync(editor->popupMenuOptions(this, false),
+                                      Surge::GUI::makeEndHoverCallback(c));
         }
         break;
         default:

diff --git a/src/surge-xt/gui/overlays/MSEGEditor.cpp b/src/surge-xt/gui/overlays/MSEGEditor.cpp
@@ -3038,7 +3038,8 @@ int32_t MSEGControlRegion::controlModifierClicked(Surge::GUI::IComponentTagValue
                                 showTypein);
         }
 
-        contextMenu.showMenuAsync(sge->popupMenuOptions());
+        contextMenu.showMenuAsync(sge->popupMenuOptions(),
+                                  Surge::GUI::makeEndHoverCallback(pControl));
     }
     return 1;
 }

diff --git a/src/surge-xt/gui/widgets/LFOAndStepDisplay.cpp b/src/surge-xt/gui/widgets/LFOAndStepDisplay.cpp
@@ -1752,9 +1752,6 @@ void LFOAndStepDisplay::shiftRight()
 
 void LFOAndStepDisplay::mouseExit(const juce::MouseEvent &event)
 {
-    lfoTypeHover = -1;
-    stepSeqShiftHover = -1;
-
     if (overWaveform)
     {
         enterExitWaveform(false);

diff --git a/src/surge-xt/gui/widgets/XMLConfiguredMenus.h b/src/surge-xt/gui/widgets/XMLConfiguredMenus.h
@@ -156,6 +156,9 @@ struct OscillatorMenu : public juce::Component,
     }
     void endHover() override
     {
+        if (stuckHover)
+            return;
+
         isHovered = false;
         repaint();
     }