Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why does get_extended modify val_max and val_default and stuff #4861

Closed
baconpaul opened this issue Aug 18, 2021 · 4 comments · Fixed by #4865
Closed

Why does get_extended modify val_max and val_default and stuff #4861

baconpaul opened this issue Aug 18, 2021 · 4 comments · Fixed by #4865
Labels
Bug Report Item submitted using the Bug Report template
Milestone
Surge XT 1.0

Comments

@baconpaul
Copy link
Collaborator

I was about to make this const and realized it isn't
Why on earth isn't it?
@baconpaul baconpaul added the Bug Report Item submitted using the Bug Report template label Aug 18, 2021
@baconpaul
Copy link
Collaborator Author

this in turn means get_display can't be const and so on.

@baconpaul baconpaul mentioned this issue Aug 18, 2021
Closed
baconpaul added a commit to baconpaul/surge that referenced this issue Aug 18, 2021
@baconpaul
Add some 'const' in parameter space
8d04882 
Addresses surge-synthesizer#3808
but see the problem in surge-synthesizer#4861
@baconpaul baconpaul mentioned this issue Aug 18, 2021
Merged
baconpaul added a commit that referenced this issue Aug 18, 2021
@baconpaul
Add some 'const' in parameter space (#4863)
2c8fcdb 
Addresses #3808
but see the problem in #4861
@mkruselj
Copy link
Collaborator

mkruselj commented Aug 18, 2021 •
edited
Loading

Because some params need to have different default and/or min/max values in extended mode only (i. e. certain params going from unipolar to bipolar etc.).

Any other way to deal with this? I couldn't figure out how to have these params update in such way exactly when toggling Extended on/off, other than this (as you can see through git blame)...

@baconpaul
Copy link
Collaborator Author

yeah the answer is to make a set_extend_range() which is non const and call it consistently and do the change there. On it.

@baconpaul
Copy link
Collaborator Author

(the reason you want things marked const correctly is so this would fail to build when we made the change, btw; its why #3808 is important).

baconpaul added a commit to baconpaul/surge that referenced this issue Aug 18, 2021
@baconpaul
Correct Const in get_extended
d850dc1 
get_extended was mutating the state of Parameter; rather than
do that add a set_extend_range and call it consistently. Add
but don't activate a mode where you can force a write to extend
into a compiler error also

Closes surge-synthesizer#4861
Addresses surge-synthesizer#3808
@baconpaul baconpaul mentioned this issue Aug 18, 2021
Merged
baconpaul added a commit that referenced this issue Aug 18, 2021
@baconpaul
Correct Const in get_extended (#4865)
bb1b247 
get_extended was mutating the state of Parameter; rather than
do that add a set_extend_range and call it consistently. Add
but don't activate a mode where you can force a write to extend
into a compiler error also

Closes #4861
Addresses #3808
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template
Projects
None yet
Milestone
Surge XT 1.0
Development

Successfully merging a pull request may close this issue.

Correct Const in get_extended baconpaul/surge
2 participants
@mkruselj @baconpaul