Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go sweep for constness and stuff #3808

Closed
baconpaul opened this issue Feb 4, 2021 · 4 comments · Fixed by #4899
Closed

Go sweep for constness and stuff #3808

baconpaul opened this issue Feb 4, 2021 · 4 comments · Fixed by #4899
Labels
Code Refactoring General code refactoring and cleanup issues like names, unused variables, warnings, fixme
Milestone
Surge XT 1.0

Comments

@baconpaul
Copy link
Collaborator

I noticed set_value_from_string has signature (std::string s) as opposed to (const std::string &s) and that percolates out.

One we ship 1.8.2 start fixing these as a matter of course through the spring.
@baconpaul baconpaul added the Code Refactoring General code refactoring and cleanup issues like names, unused variables, warnings, fixme label Feb 4, 2021
@baconpaul baconpaul added this to the Surge XT milestone Feb 4, 2021
@baconpaul
Copy link
Collaborator Author 

grep std::string *.h gui/*.h | grep -v const | grep "("

shows a bunch of places to get a const & (or be deleted)

baconpaul added a commit to baconpaul/surge that referenced this issue Jul 20, 2021
@baconpaul
Const Sweep First Step
ed2f77d 
this change changes std::string args to const std::string & args
most places I see them incorrect. Still to do is the get arguments
get a const signature and stuff but that can come later

Addresses surge-synthesizer#3808
baconpaul added a commit to baconpaul/surge that referenced this issue Jul 20, 2021
@baconpaul
Const Sweep First Step
b382f96 
this change changes std::string args to const std::string & args
most places I see them incorrect. Still to do is the get arguments
get a const signature and stuff but that can come later

Addresses surge-synthesizer#3808
@baconpaul baconpaul mentioned this issue Jul 20, 2021
Merged
baconpaul added a commit to baconpaul/surge that referenced this issue Jul 20, 2021
@baconpaul
Const Sweep First Step
3b48f3c 
this change changes std::string args to const std::string & args
most places I see them incorrect. Still to do is the get arguments
get a const signature and stuff but that can come later

Addresses surge-synthesizer#3808
baconpaul added a commit that referenced this issue Jul 20, 2021
@baconpaul
Const Sweep First Step (#4764)
0216133 
this change changes std::string args to const std::string & args
most places I see them incorrect. Still to do is the get arguments
get a const signature and stuff but that can come later

Addresses #3808
@baconpaul
Copy link
Collaborator Author

Linking to #4861

@baconpaul
Copy link
Collaborator Author

when 4861 is resolved we can fix the rest of parameter. then move on.

baconpaul added a commit to baconpaul/surge that referenced this issue Aug 18, 2021
@baconpaul
Add some 'const' in parameter space
8d04882 
Addresses surge-synthesizer#3808
but see the problem in surge-synthesizer#4861
@baconpaul baconpaul mentioned this issue Aug 18, 2021
Merged
baconpaul added a commit that referenced this issue Aug 18, 2021
@baconpaul
Add some 'const' in parameter space (#4863)
2c8fcdb 
Addresses #3808
but see the problem in #4861
@baconpaul baconpaul mentioned this issue Aug 18, 2021
Closed
baconpaul added a commit to baconpaul/surge that referenced this issue Aug 18, 2021
@baconpaul
Correct Const in get_extended
d850dc1 
get_extended was mutating the state of Parameter; rather than
do that add a set_extend_range and call it consistently. Add
but don't activate a mode where you can force a write to extend
into a compiler error also

Closes surge-synthesizer#4861
Addresses surge-synthesizer#3808
@baconpaul baconpaul mentioned this issue Aug 18, 2021
Merged
@baconpaul
Copy link
Collaborator Author

OK with #4865 parameter is done
now onto surge synth and surge storage and then i will close this issue i think

baconpaul added a commit that referenced this issue Aug 18, 2021
@baconpaul
Correct Const in get_extended (#4865)
bb1b247 
get_extended was mutating the state of Parameter; rather than
do that add a set_extend_range and call it consistently. Add
but don't activate a mode where you can force a write to extend
into a compiler error also

Closes #4861
Addresses #3808
baconpaul added a commit to baconpaul/surge that referenced this issue Aug 18, 2021
@baconpaul
Modulation Index Support
46b69c1 
Addresses surge-synthesizer#4868

1. Add a source index to modrouting and stream it
2. Use that modrouting to lookup values in processing (but not in all the 'is' or 'get' apis)
3. Const up a bunch of stuff along the way (workign on surge-synthesizer#3808)
baconpaul added a commit to baconpaul/surge that referenced this issue Aug 19, 2021
@baconpaul
Modulation Index Support
8b43989 
Addresses surge-synthesizer#4868

1. Add a source index to modrouting and stream it
2. Use that modrouting to lookup values in processing (but not in all the 'is' or 'get' apis)
3. Const up a bunch of stuff along the way (workign on surge-synthesizer#3808)
4. Plumbing through vector value to formula mod
5. Modify the UI so that by menus you can map formula modulators but not
   by click-to-arm yet.
@baconpaul baconpaul mentioned this issue Aug 19, 2021
Merged
baconpaul added a commit to baconpaul/surge that referenced this issue Aug 19, 2021
@baconpaul
Modulation Index Support
9668b73 
Addresses surge-synthesizer#4868

1. Add a source index to modrouting and stream it
2. Use that modrouting to lookup values in processing (but not in all the 'is' or 'get' apis)
3. Const up a bunch of stuff along the way (workign on surge-synthesizer#3808)
4. Plumbing through vector value to formula mod
5. Modify the UI so that by menus you can map formula modulators but not
   by click-to-arm yet.
baconpaul added a commit that referenced this issue Aug 19, 2021
@baconpaul
Modulation Index Support (#4870)
e758bec 
Addresses #4868

1. Add a source index to modrouting and stream it
2. Use that modrouting to lookup values in processing (but not in all the 'is' or 'get' apis)
3. Const up a bunch of stuff along the way (workign on #3808)
4. Plumbing through vector value to formula mod
5. Modify the UI so that by menus you can map formula modulators but not
   by click-to-arm yet.
baconpaul added a commit to baconpaul/surge that referenced this issue Aug 23, 2021
@baconpaul
Enough constness for XT
ee59e7e 
Final constness changes. No need for an open issue now. Do more
as opportunity arriese but Closes surge-synthesizer#3808
@baconpaul baconpaul mentioned this issue Aug 23, 2021
Merged
baconpaul added a commit that referenced this issue Aug 24, 2021
@baconpaul
Enough constness for XT (#4899)
8852029 
Final constness changes. No need for an open issue now. Do more
as opportunity arriese but Closes #3808
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Code Refactoring General code refactoring and cleanup issues like names, unused variables, warnings, fixme
Projects
None yet
Milestone
Surge XT 1.0
Development

Successfully merging a pull request may close this issue.

Enough constness for XT baconpaul/surge
2 participants
@mkruselj @baconpaul