-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Accessibility Handlers to the TinyLittleIconButton (was: Expanded multi button menus) #4418
Comments
mute too next to that obvs |
might I propose two buttons... one for clear (an x) and another to edit (a pencil) |
Yeah clear and mute for sure - the menu can do something if you click outside the button but we can add a pencil too. |
There's no need for pencil. I bet we can make the value displayed a text edit field directly. I can only see the real need for Clear and Mute buttons. |
So I started hacking on this and I realized its gonna run head first into the accessibility changes if I'm not careful. Need to think a bit.
|
This creates an expanded menu which has an X Mute and Edit icon rather than the word "Edit" collapsing the "Edit/Clear" and adding a "Mute", but currently only does it on target (slider) modulators not source (LFO, Macro) modulators while we get feedback. Addresses surge-synthesizer#4418
This creates an expanded menu which has an X Mute and Edit icon rather than the word "Edit" collapsing the "Edit/Clear" and adding a "Mute", but currently only does it on target (slider) modulators not source (LFO, Macro) modulators while we get feedback. Addresses #4418
More work on the Parameter Menu 1. Visually separate the header 2. Don't repeat the target name 3. Compress the clear and unmute 4. Generally reorder it to be more sensible Addresses surge-synthesizer#4418
More work on the Parameter Menu 1. Visually separate the header 2. Don't repeat the target name 3. Compress the clear and unmute 4. Generally reorder it to be more sensible Addresses surge-synthesizer#4418
More work on the Parameter Menu 1. Visually separate the header 2. Don't repeat the target name 3. Compress the clear and unmute 4. Generally reorder it to be more sensible Addresses #4418
Addressing the surge-synthesizer#4418 checklist some
Addressing the surge-synthesizer#4418 checklist some
Addressing the #4418 checklist some
Make the sources have an extended menu also. Addresses and almost but not quite gets us done with surge-synthesizer#4418
Make the sources have an extended menu also. Addresses and almost but not quite gets us done with surge-synthesizer#4418
Make the sources have an extended menu also. Addresses and almost but not quite gets us done with surge-synthesizer#4418
Make the sources have an extended menu also. Addresses and almost but not quite gets us done with surge-synthesizer#4418
Make the sources have an extended menu also. Addresses and almost but not quite gets us done with #4418
OK so right now this menu shows up this way in accessible query
which is 'bad' |
Accesible handlers for all the components in the modulation menu, including labels, actions, etc... and a small script to exercise them Closes surge-synthesizer#4418
And after I merge #5368 we will get
which is "good" |
Accesible handlers for all the components in the modulation menu, including labels, actions, etc... and a small script to exercise them Closes #4418
Only thing left is accessibility APIs
Talking on discord @mkruselj and I thought of turning this menu
into the far mode compact version where the edit menu item also has a 'clear' button. So it becomes kinda like this with that red box being a "x" of some sort. (@mkruselj wanted to get rid of those edit and clear altogether but the rest of us didn't like that idea at all!).
So this issue is: can I use a custom menu renderer to have the menu send two different messages somehow and plumb it through so that is doable and the menu is more compact. Placeholder so we don't forget the convo.
This also relates to #2049 but is obviously distinct.
The text was updated successfully, but these errors were encountered: