Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modulation overview panel #2049

Closed
mkruselj opened this issue Jun 6, 2020 · 6 comments
Closed

Modulation overview panel #2049

mkruselj opened this issue Jun 6, 2020 · 6 comments
Labels
Design Required We need to design a solution to this issue Feature Request New feature request Modulation Modulation related issues UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. WIP Issues that are an ongoing work in progress
Milestone

Comments

@mkruselj
Copy link
Collaborator

mkruselj commented Jun 6, 2020

Right now, this is a bit all over the place in Surge. There is no easy way to see and edit all assigned modulators to a particular parameter from one place. We have RMB context menu typeins option (which is neat to have for sure), but I'm thinking a much better way to go about this would be to have a "Show modulations" option in the context menu, which then launches a window where you're greeted with sliders for each and every possible modulator in Surge, so that you can tweak all of them from that very place. Very quick, very convenient.

image

Additionally, we should have a vice-versa sort of thing on the mod assign tabs themselves. Right now when you RMB them you get a context menu with all currently assigned modulations listed, and yes you can click each and type in a value. But it'd be so much better to just have it with sliders, with additional buttons to clear each individual modulation or clear all. ADDING a modulation target from here might be a bit of a tough ask, but it would be spectacular, for completionist's sake.

@mkruselj mkruselj added Feature Request New feature request Modulation Modulation related issues UI Issues related to UI look&feel UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. labels Jun 6, 2020
@K0rrid0r
Copy link
Collaborator

K0rrid0r commented Jun 6, 2020

100% agreed on this idea!

@baconpaul baconpaul added this to the 1.7.n milestone Jun 7, 2020
@mkruselj mkruselj modified the milestones: 1.7.n, 1.7.1 Jul 17, 2020
@mkruselj mkruselj modified the milestones: 1.7.1, 1.7.2 Jul 30, 2020
@mkruselj
Copy link
Collaborator Author

We can now see which modulators are modulating a particular parameter by changing the font color of the involved modulators - which is nice from a general overview perspective. However, being able to simultaneously see all modulation amounts per target in one place is a considerable workflow boost.

Now that @baconpaul did a modal pop-up window for editing whatever (in this case MSEG), we can reuse this functionality exactly for this specific FR!

@mkruselj mkruselj modified the milestones: 1.7.2, 1.7.n Sep 8, 2020
@mkruselj mkruselj modified the milestones: 1.8.n, 1.9.0 Oct 8, 2020
@mkruselj mkruselj modified the milestones: 1.9.0, Surge XT Jan 24, 2021
baconpaul added a commit to baconpaul/surge that referenced this issue Apr 30, 2021
1. Implement a ModEditorWindow class which does basic text dump
2. Hook it up to the RMB sliders
3. Clean up the copyright headers on the new code I've been working on

Addresses surge-synthesizer#2049
baconpaul added a commit that referenced this issue Apr 30, 2021
1. Implement a ModEditorWindow class which does basic text dump
2. Hook it up to the RMB sliders
3. Clean up the copyright headers on the new code I've been working on

Addresses #2049
baconpaul added a commit to baconpaul/surge that referenced this issue May 2, 2021
values modify, synth updated, etc...

Still a lot to do but this is a great proof of concept

Addresses surge-synthesizer#2049
baconpaul added a commit that referenced this issue May 2, 2021
values modify, synth updated, etc...

Still a lot to do but this is a great proof of concept

Addresses #2049
@mkruselj
Copy link
Collaborator Author

mkruselj commented May 7, 2021

Notes for @baconpaul.

I can imagine three modes of operation for the new modulation overview panel:

  1. Show the whole lot, perhaps filterable by section, modulator...
  2. Show only the current parameter, but all modulators that can be assigned to it (even those modulations coming from modulators that are not currently assigned to the parameter we're displaying)
  3. Show only a single modulator with everything it modulates (with dropdown to choose which modulator to display)

In modes 1 and 3 we should be able to create new and remove existing assignments. In all three modes we should be able to mute modulations. Removing an assignment in mode 2 should just default it to 0%, but widget for tweaking that modulator's modulation amount should always exist.

@mkruselj
Copy link
Collaborator Author

Would be great UX if the modulation overview panel opens in a different mode based on where you open it from.

  • If opening from a parameter, open it in mode 2
  • If opening from a modbutton, open it in mode 3

Then perhaps we can figure out a location for a global modulation overview button, perhaps . The redesigned GUI doesn't have a lot of places where this could fit.

baconpaul added a commit to baconpaul/surge that referenced this issue Aug 23, 2021
Lots of work to do on the modulation overview, but to make
it at least passably usable, sort the rows by something
reasonable

Addresses surge-synthesizer#2049
baconpaul added a commit that referenced this issue Aug 23, 2021
Lots of work to do on the modulation overview, but to make
it at least passably usable, sort the rows by something
reasonable

Addresses #2049
@mkruselj mkruselj changed the title Improved modulation overview/editing Modulation overview panel Aug 29, 2021
@mkruselj mkruselj added Design Required We need to design a solution to this issue WIP Issues that are an ongoing work in progress and removed UI Issues related to UI look&feel labels Aug 29, 2021
baconpaul added a commit to baconpaul/surge that referenced this issue Aug 29, 2021
This will allow us int he future to let the context menus set
filters on the overview and still have the global view available

Addresses surge-synthesizer#2049
baconpaul added a commit that referenced this issue Aug 29, 2021
This will allow us int he future to let the context menus set
filters on the overview and still have the global view available

Addresses #2049
@baconpaul
Copy link
Collaborator

Note I have to call refresh mod when doing dstedturive or constructive operations from the window

@baconpaul
Copy link
Collaborator

Closing and moving to a book of work #5323

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design Required We need to design a solution to this issue Feature Request New feature request Modulation Modulation related issues UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. WIP Issues that are an ongoing work in progress
Projects
None yet
Development

No branches or pull requests

3 participants