Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move FX Copy Paste into the storage #2130

Closed
baconpaul opened this issue Jun 17, 2020 · 1 comment · Fixed by #4642
Closed

Move FX Copy Paste into the storage #2130

baconpaul opened this issue Jun 17, 2020 · 1 comment · Fixed by #4642
Labels
Code Refactoring General code refactoring and cleanup issues like names, unused variables, warnings, fixme Infrastructure Issues related to repository, CI/CD, installers, etc.
Milestone
Surge XT 1.0

Comments

@baconpaul
Copy link
Collaborator

baconpaul commented Jun 17, 2020 •
edited
Loading

FX Copy/Paste is some nonsense I made up in CSnapshotMenu

It could really be a copy-paste type in storage (SurgeStorage::clipboard_paste and so on)

but not for 1.7.0. Fix it in a later release.
@baconpaul baconpaul added this to the 1.7.n milestone Jun 17, 2020
@mkruselj mkruselj added the Infrastructure Issues related to repository, CI/CD, installers, etc. label Jun 17, 2020
@mkruselj mkruselj modified the milestones: 1.7.n, 1.7.1 Jul 17, 2020
@baconpaul baconpaul modified the milestones: 1.7.1, Currently Unscheduled Aug 2, 2020
@mkruselj mkruselj added the Code Refactoring General code refactoring and cleanup issues like names, unused variables, warnings, fixme label Nov 9, 2020
@mkruselj mkruselj mentioned this issue Dec 29, 2020
Closed
@mkruselj
Copy link
Collaborator

Linking #2095 here.

@mkruselj mkruselj modified the milestones: 1.9.0, Surge XT 1.0 Mar 17, 2021
baconpaul added a commit to baconpaul/surge that referenced this issue Jun 4, 2021
@baconpaul
FX Copy and Paste, Preset out of the widget
177f44f 
1. FX Preset Management to common/FxUserPresetManager
2. Move copy and paste into the same manager (rather than storage).
Closes surge-synthesizer#2130
@baconpaul baconpaul mentioned this issue Jun 4, 2021
Merged
baconpaul added a commit that referenced this issue Jun 4, 2021
@baconpaul
FX Copy and Paste, Preset out of the widget (#4642)
dd650d0 
1. FX Preset Management to common/FxUserPresetManager
2. Move copy and paste into the same manager (rather than storage).
Closes #2130
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Code Refactoring General code refactoring and cleanup issues like names, unused variables, warnings, fixme Infrastructure Issues related to repository, CI/CD, installers, etc.
Projects
None yet
Milestone
Surge XT 1.0
Development

Successfully merging a pull request may close this issue.

FX Copy and Paste, Preset out of the widget baconpaul/surge
2 participants
@mkruselj @baconpaul