Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Copy with Modulation' option for SEQ LFO and FX #2095

Closed
ghost opened this issue Jun 11, 2020 · 4 comments · Fixed by #5181
Closed

Add 'Copy with Modulation' option for SEQ LFO and FX #2095

ghost opened this issue Jun 11, 2020 · 4 comments · Fixed by #5181
Labels
Feature Request New feature request UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Milestone

Comments

@ghost
Copy link

ghost commented Jun 11, 2020

From Slack discussion 20200610

Jacky
Surge 1.7 beta Q:

When copying the settings of one modulation source (LFO, SEQ, etc.) to another modulation slot, if there are modulation assignments made to controls on the source being copied - i.e - LFOs/SEQs modulating each other's parameters, should those cross-modulation assignments - theoretically in practice - be a part of the copy?

FWIW, copying any modulation assignments from other sources, might be the ideal behavior for quickly setting up variant modulations from the copied source, thereby eliminating the need to have to reassign them after the copy. Your opinion? Any drawbacks to copying modulation assignments from other modulation sources that occur?

baconpaul
So the way we did it with oscillators is we have “copy” and “copy with modulation” as two distinct things so the user picks. We should do the same with LFOs. Sometimes you want it sometimes you don’t basically.

Good observation that we lack the capability though (even though we have it on OSC). We should also add it to the copy/paste on FX which also is value only not value-and-mod.

Wanna toss in an issue and we can do it after 1.7.0!

@baconpaul baconpaul added the Modulation Modulation related issues label Jun 11, 2020
@baconpaul
Copy link
Collaborator

While we are at it, we should add it to the FX too. Good observation!

@baconpaul baconpaul added this to the 1.7.n milestone Jun 11, 2020
@baconpaul baconpaul added the UI Issues related to UI look&feel label Jun 11, 2020
@baconpaul baconpaul modified the milestones: 1.7.n, 1.7.1 Jul 17, 2020
@baconpaul baconpaul changed the title Add 'Copy with Modulation' option for SEQ and LFO Add 'Copy with Modulation' option for SEQ LFO and FX Jul 17, 2020
@baconpaul baconpaul modified the milestones: 1.7.1, Currently Unscheduled Aug 2, 2020
@mkruselj mkruselj added the Feature Request New feature request label Nov 9, 2020
@mkruselj mkruselj added UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. and removed Modulation Modulation related issues UI Issues related to UI look&feel labels Dec 23, 2020
@mkruselj
Copy link
Collaborator

Moreover, in FX menu we always see Copy and Paste options, whereas elsewhere Paste only shows up when there's something to copy. We should make it more consistent then for the FX menu, only show Copy and Copy with Modulation options, then once we have copied, show Paste the next time menu is opened.

@baconpaul
Copy link
Collaborator

As well as "Copy with modulation" we should have a "Copy Routings Only" option probably.

@mkruselj
Copy link
Collaborator

mkruselj commented Jul 7, 2021

Yes, so that we can copy from LFO to velocity, and so on...

baconpaul added a commit to baconpaul/surge that referenced this issue Sep 30, 2021
Copy and Paste Modulation Routings

1. LFO get a Copy, Copy with, Copy Just
2. Others get a Copy Just
3. All get a paste that does the right thing

Closes surge-synthesizer#2095
baconpaul added a commit that referenced this issue Sep 30, 2021
Copy and Paste Modulation Routings

1. LFO get a Copy, Copy with, Copy Just
2. Others get a Copy Just
3. All get a paste that does the right thing

Closes #2095
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request New feature request UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants