Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hover is intermittent - Linux VST3 #1817

Closed
tank-trax opened this issue May 7, 2020 · 9 comments · Fixed by #2254
Closed

Hover is intermittent - Linux VST3 #1817

tank-trax opened this issue May 7, 2020 · 9 comments · Fixed by #2254
Labels
Linux Issues which only occur on Linux UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Milestone

Comments

@tank-trax
Copy link
Collaborator

Using Debian Buster Linux

  • hover often requires a mouse down click to enable/activate

  • for example, after a preset is selected from the Patch Browser, hover does not initiate

  • after clicking down on the GUI hover appears when passing the mouse over those elements that hover

  • sometimes it requires two clicks to get it working

here is an example

Happens on VST3 in Carla and Bitwig
Does not happen in VST3 in Reaper
Does not happen in VST2 in Reaper, Carla or Bitwig

@mkruselj mkruselj added Linux Issues which only occur on Linux UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. labels May 7, 2020
@baconpaul baconpaul added this to the 1.7 beta 1 milestone May 8, 2020
@tank-trax
Copy link
Collaborator Author

I've noticed a few patterns with regards to the hover intermittent behavior.

In the Modulation section when the mouse passes over the menu to select the Waveform LFO Shapes or Trigger mode it often displays an arrow whereas it should be a hand.

When the hand appears while hovering over the Waveform LFO Shapes menu it may have an arrow over the Trigger mode menu. Clicking elements within the Waveform LFO Shapes menu may return a hand when hovering over the Trigger mode menu, occasionally returning an arrow.

hover-vst3 01

In this animated gif the arrow will become a hand on a click down event, the Trigger mode menu has a hand hovering and the hover will work on the Waveshaper menu. However it appears to lose its focus once it hovers above the Filter option buttons.
hover-vst3

@tank-trax
Copy link
Collaborator Author

In this instance the hover works over the Oscillator and Scene sections and loses focus when it passes over the Filter section.

Returning to Waveform LFO Shapes menu the Mouse is now an arrow and will change to a hand on a left click down. Returning to the Oscillator section though the mouse remains a hand. Clicking again on the Waveform LFO Shapes menu and when returning to the Oscillator section mouse appears as an arrow and the hover works, once again losing focus over the Filter section.

hover-vst3 02

@baconpaul
Copy link
Collaborator

So the hands are just because I haven't fully backed out #1752 hand gesture yet. I'll do so.

The hover is more worrying and i see it too. It is, of course, most likely event loop related and we are just not getting the events.

@bgins
Copy link
Contributor

bgins commented Jun 30, 2020

I'm also seeing intermittent behavior on Ubuntu 18.04, Bitwig studio, nightly 823b1f2. The hover gets stuck after selecting something:

hover-stuck

Either selecting another thing or clicking clicking somewhere else on the GUI clears the hover.

@baconpaul
Copy link
Collaborator

yeah the xcb hover delivery just hangs up on me and I can't figure out why. Forcing it by doing a click seems to start the events again. Do you happen to know a lot about xcb? If so I could definitely use some help. (If not I will keep plugging away at it of course).

@bgins
Copy link
Contributor

bgins commented Jun 30, 2020

I'm not familiar with xcb. If I were, I'd be happy to look into it.

@baconpaul
Copy link
Collaborator

Thanks! Figured it didn't hurt to ask

I think the problem is vstgui and xcb somewhere ... I keep getting close. But this is in the 170 milestone so I really do intend to fix it.

@baconpaul
Copy link
Collaborator

Just figured it out.

baconpaul added a commit to baconpaul/surge that referenced this issue Jun 30, 2020
the FDI based VST3 event loop would hang up, so kick it on
the idle. Comment inline in source with more details

Closes surge-synthesizer#1817
baconpaul added a commit that referenced this issue Jun 30, 2020
the FDI based VST3 event loop would hang up, so kick it on
the idle. Comment inline in source with more details

Closes #1817
@bgins
Copy link
Contributor

bgins commented Jun 30, 2020

That fixed it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Linux Issues which only occur on Linux UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants