Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish Default Skin Hover Assets #1752

Closed
21 of 22 tasks
baconpaul opened this issue Apr 22, 2020 · 2 comments · Fixed by #2358
Closed
21 of 22 tasks

Finish Default Skin Hover Assets #1752

baconpaul opened this issue Apr 22, 2020 · 2 comments · Fixed by #2358
Labels
UI Issues related to UI look&feel UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Milestone
1.7.0

Comments

@baconpaul
Copy link
Collaborator

baconpaul commented Apr 22, 2020 •
edited
Loading

OK here's the places we need it still

  • 112 - filter config dark
  • 113 - AB light
  • 114 - key split light
  • 117 and 118 - octave dark
  • 119 osc select (may need code)
  • 120 ws light
  • 121 link light
  • 122 osc select dark
  • 125 keytrigger
  • 126 retrigger
  • 132 solo
  • 140 link
  • 143 filter select
  • 144 fx send
  • 146 lfo trigger
  • 148 store
  • 149 jog
  • 151 fm
  • 152 unipolar
  • 160 filter type
  • menu
  • jog

(finish this list later)
@mkruselj mkruselj added UI Issues related to UI look&feel UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. labels Apr 23, 2020
@mkruselj
Copy link
Collaborator

Hands only show on slider handle, despite the fact that you can drag the slider from any point on it, even if it's not a handle.

I really wonder if this is required on sliders, tho. I know, consistency, but can't say I saw many plugins which change cursors on each and every parameter?

@baconpaul baconpaul changed the title Hands Active UI Feedback (was: Hands. Now is Hands and Hover) Apr 26, 2020
baconpaul added a commit to baconpaul/surge that referenced this issue Apr 26, 2020
@baconpaul
Begin implementation of HoverStates
19b6a12 
Begin implementation of HoverStates. This change

1. Plubms through hover state API on the skin engine
2. Implements a default hover state
3. Makes CHSwitch2 an accurate client of that
4. Adds bad hover graphics for filter and waveshaper switches

Committing here so designers can start using this feature on the
switches while we code up other elements.

Addresses surge-synthesizer#1752
@baconpaul baconpaul mentioned this issue Apr 26, 2020
Merged
baconpaul added a commit that referenced this issue Apr 26, 2020
@baconpaul
Begin implementation of HoverStates (#1757)
441bb00 
Begin implementation of HoverStates. This change

1. Plubms through hover state API on the skin engine
2. Implements a default hover state
3. Makes CHSwitch2 an accurate client of that
4. Adds bad hover graphics for filter and waveshaper switches

Committing here so designers can start using this feature on the
switches while we code up other elements.

Addresses #1752
@baconpaul baconpaul added this to the 1.7 beta 1 milestone May 2, 2020
@baconpaul baconpaul mentioned this issue May 19, 2020
Closed
baconpaul added a commit to baconpaul/surge that referenced this issue May 19, 2020
@baconpaul
Turn off the Hand Cursor
d663516 
We decided to go with the Hover Gesture instead, so turn off
the hand and work on hovers. Addresses surge-synthesizer#1752
@baconpaul baconpaul mentioned this issue May 19, 2020
Merged
baconpaul added a commit that referenced this issue May 19, 2020
@baconpaul
Turn off the Hand Cursor (#1916)
03fb460 
We decided to go with the Hover Gesture instead, so turn off
the hand and work on hovers. Addresses #1752
baconpaul added a commit to baconpaul/surge that referenced this issue May 20, 2020
@baconpaul
Hover and Skin for CModSourceButton
a2b7e26 
CModSourceButton is drawn and the colors weren't skinned.
This fixes that bu introducing a mess of skin colors including
hover frames and fonts, and setting the default hovers to a 40%
boost.

Closes surge-synthesizer#1890
Addresses surge-synthesizer#1752
@baconpaul baconpaul mentioned this issue May 20, 2020
Merged
baconpaul added a commit that referenced this issue May 20, 2020
@baconpaul
Hover and Skin for CModSourceButton (#1917)
7ac5e76 
CModSourceButton is drawn and the colors weren't skinned.
This fixes that bu introducing a mess of skin colors including
hover frames and fonts, and setting the default hovers to a 40%
boost.

Closes #1890
Addresses #1752
@baconpaul baconpaul mentioned this issue May 28, 2020
Closed
@baconpaul baconpaul changed the title Active UI Feedback (was: Hands. Now is Hands and Hover) Active UI Feedback (was: Hands. Now is Hover) May 29, 2020
baconpaul added a commit to baconpaul/surge that referenced this issue Jun 20, 2020
@baconpaul
Add Hover for Sliders
bbc37bc 
Sliders can get hover budies which paint over the handles.
Addresses surge-synthesizer#1752
@baconpaul baconpaul mentioned this issue Jun 20, 2020
Merged
baconpaul added a commit to baconpaul/surge that referenced this issue Jun 20, 2020
@baconpaul
Add Hover for Sliders
5e7e47b 
Sliders can get hover budies which paint over the handles.
Addresses surge-synthesizer#1752
baconpaul added a commit that referenced this issue Jun 20, 2020
@baconpaul
Add Hover for Sliders (#2166)
8d8ccb7 
Sliders can get hover budies which paint over the handles.
Addresses #1752
@baconpaul baconpaul changed the title Active UI Feedback (was: Hands. Now is Hover) Finish Default Skin Hover Assets Jun 23, 2020
@baconpaul
Copy link
Collaborator Author

PW notes to self

light images
offset
553300 on ffeeaa in hov
000000 on ffffff in on

dark images
hoverOn has a gradient
hover alone has a different gradient
sigh

baconpaul added a commit to baconpaul/surge that referenced this issue Jul 10, 2020
@baconpaul
Hover Assets for the Default Skin continued
838609f 
Hover assets for all the light-backgrounded components of the
default ski

Addresses surge-synthesizer#1752
@baconpaul baconpaul mentioned this issue Jul 10, 2020
Merged
baconpaul added a commit that referenced this issue Jul 10, 2020
@baconpaul
Hover Assets for the Default Skin continued (#2327)
5636d63 
Hover assets for all the light-backgrounded components of the
default ski

Addresses #1752
baconpaul added a commit to baconpaul/surge that referenced this issue Jul 10, 2020
@baconpaul
More default skin hovers
76fc679 
- waveshaper
- digital/analog
- solo

Addresses surge-synthesizer#1752
@baconpaul baconpaul mentioned this issue Jul 10, 2020
Merged
baconpaul added a commit that referenced this issue Jul 10, 2020
@baconpaul
More default skin hovers (#2329)
7c75e8c 
- waveshaper
- digital/analog
- solo

Addresses #1752
baconpaul added a commit to baconpaul/surge that referenced this issue Jul 16, 2020
@baconpaul
Complete Default Skin hover assets
787db61 
Closes surge-synthesizer#1752
@baconpaul baconpaul mentioned this issue Jul 16, 2020
Merged
baconpaul added a commit that referenced this issue Jul 16, 2020
@baconpaul
Complete Default Skin hover assets (#2358)
0db9dbe 
Closes #1752
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
UI Issues related to UI look&feel UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Projects
None yet
Milestone
1.7.0
Development

Successfully merging a pull request may close this issue.

Complete Default Skin hover assets baconpaul/surge
2 participants
@mkruselj @baconpaul