Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipline Unit Test Boogers #1654

Closed
baconpaul opened this issue Mar 21, 2020 · 9 comments · Fixed by #1656
Closed

Pipline Unit Test Boogers #1654

baconpaul opened this issue Mar 21, 2020 · 9 comments · Fixed by #1656
Labels
Infrastructure Issues related to repository, CI/CD, installers, etc.
Milestone
1.7.0

Comments

@baconpaul
Copy link
Collaborator

Tired of these. But now @itsmedavep saw one too so write em down and start fixing

ADSR Envelope Behaviour
Clone the Analog

D:\a\1\s\src\headless\UnitTestsMOD.cpp(431)
...............................................................................

D:\a\1\s\src\headless\UnitTestsMOD.cpp(443): FAILED:
REQUIRE( replA[i].second == Approx( surgeA[i].second ).margin( 1e-6 ) )
with expansion:
0.0f == Approx( 0.0 )
with message:
Testing 45 with ADSR=0.442091 0.813949 0.254518 0.990041
@baconpaul
Copy link
Collaborator Author

Unison at Sample Rates
Classic Oscillator

/Users/runner/runners/2.165.2/work/1/s/src/headless/UnitTestsDSP.cpp:239
...............................................................................

/Users/runner/runners/2.165.2/work/1/s/src/headless/UnitTestsDSP.cpp:205: FAILED:
REQUIRE( 16.f * abss == Approx( fn_0 - fn_1 ).margin( 0.3 ) )
with expansion:
4.40846f == Approx( -10.1798324585 )
with messages:
Classic test at 88200
Test[9] note=33 at absolute spread 0.275529 = 4.4 Hz

@baconpaul
Copy link
Collaborator Author

The first is just a too-close-to-zero. The second is I think a threading problem in the test.

baconpaul added a commit to baconpaul/surge that referenced this issue Mar 22, 2020
@baconpaul
Tighten up a couple of spots in the unit tests
58514ef 
A couple of spots in the unit tests fail in the pipelines.
One because of a bad bounce near zero, one because of
(I think) a threading issue.

Address both.

Closes surge-synthesizer#1654
@baconpaul baconpaul mentioned this issue Mar 22, 2020
Merged
baconpaul added a commit that referenced this issue Mar 22, 2020
@baconpaul
Tighten up a couple of spots in the unit tests (#1656)
2e7b114 
A couple of spots in the unit tests fail in the pipelines.
One because of a bad bounce near zero, one because of
(I think) a threading issue.

Address both.

Closes #1654
@baconpaul
Copy link
Collaborator Author

ADSR Envelope Behaviour
Clone the Analog

/Users/runner/runners/2.165.2/work/1/s/src/headless/UnitTestsMOD.cpp:431
...............................................................................

/Users/runner/runners/2.165.2/work/1/s/src/headless/UnitTestsMOD.cpp:444: FAILED:
REQUIRE( replA[i].second == Approx( surgeA[i].second ).margin( 1e-6 ) )
with expansion:
0.25398f == Approx( 0.1945552826 )
with message:
Testing 23 with ADSR=1.02111 0.608594 0.503957 0.0124058

@baconpaul baconpaul reopened this Mar 23, 2020
@baconpaul
Copy link
Collaborator Author

Test Each Oscillator

/Users/runner/runners/2.165.2/work/1/s/src/headless/UnitTestsDSP.cpp:226
...............................................................................

/Users/runner/runners/2.165.2/work/1/s/src/headless/UnitTestsDSP.cpp:205: FAILED:
REQUIRE( 16.f * abss == Approx( fn_0 - fn_1 ).margin( 0.3 ) )
with expansion:
4.52509f == Approx( -9.6806564331 )
with messages:
Classic Oscillator test at 88200
Test[7] note=33 at absolute spread 0.282818 = 4.5 Hz

@mkruselj mkruselj added the Infrastructure Issues related to repository, CI/CD, installers, etc. label Apr 11, 2020
@baconpaul
Copy link
Collaborator Author

/Users/runner/runners/2.165.2/work/1/s/src/headless/UnitTestsMOD.cpp:444: FAILED:
REQUIRE( replA[i].second == Approx( surgeA[i].second ).margin( 1e-6 ) )
with expansion:
0.9904f == Approx( 1.0036486387 )
with message:
Testing 70 with ADSR=0.794041 0.241521 0.225826 0.0956928

@baconpaul
Copy link
Collaborator Author

So looks like the MOD 444 with very short releases blows up.

baconpaul added a commit to baconpaul/surge that referenced this issue Apr 13, 2020
@baconpaul
Fix a collection of flanger issues
c50c3ee 
Overnight @mkruselj gave a bunch of super useful feedback on
the flanger. This fixes the easy parts of that feedback.

Addresses surge-synthesizer#1708

Also kills a surge-synthesizer#1654 booger
@baconpaul baconpaul mentioned this issue Apr 13, 2020
Merged
baconpaul added a commit that referenced this issue Apr 13, 2020
@baconpaul
Fix a collection of flanger issues (#1712)
acaba7e 
Overnight @mkruselj gave a bunch of super useful feedback on
the flanger. This fixes the easy parts of that feedback.

Addresses #1708

Also kills a #1654 booger
@baconpaul
Copy link
Collaborator Author

/home/vsts/work/1/s/src/headless/UnitTestsMOD.cpp:444: FAILED:
REQUIRE( replA[i].second == Approx( surgeA[i].second ).margin( 1e-6 ) )
with expansion:
0.0f == Approx( 0.0 )
with message:
Testing 25 with ADSR=0.427551 0.961725 0.286613 0.858106

@baconpaul
Copy link
Collaborator Author

D:\a\1\s\src\headless\UnitTestsMOD.cpp(608): FAILED:
REQUIRE( fUpD == Approx( fUpB ).margin( 3 * bUp ) )
with expansion:
2812.0217285156

Approx( 2933.9165039063 )
with message:
Retuning pitch bend to test-data/scl/6-exact.scl

@baconpaul
Copy link
Collaborator Author

I think I got all these. I’ll reopen it if more show up

@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Infrastructure Issues related to repository, CI/CD, installers, etc.
Projects
None yet
Milestone
1.7.0
Development

Successfully merging a pull request may close this issue.

Tighten up a couple of spots in the unit tests baconpaul/surge
2 participants
@mkruselj @baconpaul