Surge-VST2: build-osx.sh: VST2.4SDK not correctly referenced, so Surge.dylib not correctly built #113

esaruoho · 2018-12-19T04:41:28Z

i'm wondering if i'm supposed to be able to build a macOS VST even with vst2.4sdk (working) there. this is what build-osx.sh says:

/bin/sh -c /Users/esaruoho/work/surge/obj/x64/Release/surge-vst2/surge-vst2.build/Script-9607AE3710C85E8F00CD1376.sh
Creating VST Bundle...
cp: target/vst2/Release/Surge.dylib: No such file or directory

** BUILD FAILED **

(from #110 )
Hi, I've got the export set ( export VST2SDK_DIR="~/work/VST2.4SDK" ) yet when I go to build surge-vst2 with xcode, I get these:

'public.sdk/source/vst2.x/aeffeditor.h' file not found (aeffguieditor.h)
'public.sdk/source/vst2.x/audioeffectx.h' file not found (Vst2PluginInstance.h)
'public.sdk/source/vst2.x/aeffeditor.h' file not found (aeffguieditor.h)

should these be found? they are most certainly "in there" ( see https://github.com/kurasu/surge/issues/113#issuecomment-448598752 ).. but somehow premake5.lua does not seem to find them. what am i missing?

The text was updated successfully, but these errors were encountered:

esaruoho · 2018-12-19T04:54:52Z

this seems to be caused by premake5.lua not correctly referencing the folders

/Users/esaruoho/work/surge/src/vst2/Vst2PluginInstance.cpp:5:
src/vst2/Vst2PluginInstance.h:6:10: 
fatal error:  'public.sdk/source/vst2.x/audioeffectx.h' file  not  found
#include "public.sdk/source/vst2.x/audioeffectx.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

and

In file included from /Users/esaruoho/work/surge/src/common/SurgeSynthesizer.cpp:23:
/Users/esaruoho/work/surge/src/vst2/Vst2PluginInstance.h:6:10: fatal error: 'public.sdk/source/vst2.x/audioeffectx.h' file not found
#include "public.sdk/source/vst2.x/audioeffectx.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

/Users/esaruoho/work/surge/vst3sdk/vstgui4/vstgui/plugin-bindings/aeffguieditor.h:9:10: fatal error: 'public.sdk/source/vst2.x/aeffeditor.h' file not found
#include "public.sdk/source/vst2.x/aeffeditor.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

and

vst3sdk/vstgui4/vstgui/plugin-bindings/aeffguieditor.h:9:10: fatal error: 'public.sdk/source/vst2.x/aeffeditor.h' file not found
#include "public.sdk/source/vst2.x/aeffeditor.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

i'm wondering.. these used to work, i mean, i have the

export VST2SDK_DIR="~/work/VST2.4SDK"

set alright, but yet it feels like premake5.lua is shooting these errors.

wasn't this fixed already, @asimilon @kzantow ?

esaruoho · 2018-12-19T04:59:01Z

could this be related to

        plugincommon()

        files {
                "src/vst2/**.cpp",
                "src/vst2/**.h",
                VST24SDK .. "/public.sdk/source/vst2.x/**.cpp",
                VSTGUI .. "plugin-bindings/aeffguieditor.cpp",
        }

        excludes {
                VSTGUI .. "plugguieditor.cpp",
        }

        includedirs {
                "src/vst2",
                VST24SDK,

kzantow · 2018-12-19T05:45:36Z

You don't have a valid VST2SDK_DIR set. VST24SDK in the snippet should point to a VST2 SDK dir that has a few directories, including: pluginterfaces/vst2.x/..., public.sdk/source/vst2.x/.... My comment from earlier about steinb0rg still distributing VST2 was wrong, the distro doesn't have pluginterfaces/... :(

esaruoho · 2018-12-19T13:35:44Z

@kzantow the thing with this is.. that it is a valid vst2.4sdk
export VST2SDK_DIR="~/work/VST2.4SDK"

it does contain the required files. (see image)

so what i'm really missing is, if VST2SDK_DIR is valid, the files are there, why do i get
such errors like the following not being findable

#include "public.sdk/source/vst2.x/audioeffectx.h"

is the premake5.lua looking for them in the wrong place? I'm hesitant to start copying vst2.4sdk content into vst3sdk which is a submodule grabbed from elsewhere..

esaruoho · 2018-12-19T13:41:16Z

like, is it this?

-- GLOBAL STUFF --

VSTGUI = "vst3sdk/vstgui4/vstgui/";

otoh, in premake5.lua, under linux, it is not even referencing VST2SDK_DIR. whycome?

includedirs {
        "libs/xml",
        "src/common/vt_dsp",
        "src/common/thread",
        "vst3sdk/vstgui4",
        "vst3sdk",
        "libs/"
        }

asimilon · 2018-12-19T13:45:35Z

Perhaps whoever set up the Linux target did not have VST2SDK available?

I'm going to make a clean clone on my laptop to see the outcome.

btw, this and #110 are explicitly linked, and are almost in effect duplicates, since the reason you miss a Surge.dylib is due to the build failing because it can't find the vst2 files.

esaruoho · 2018-12-19T13:49:36Z

@asimilon yep, this is why i closed #110 and copied the text from there to #113 so that this is highlighted as the same issue.

i'm getting stuff like this, and i'm not entirely sure why the builder doesn't find public.sdk/source

In file included from /Users/esaruoho/work/surge/src/vst2/Vst2PluginInstance.cpp:5:
src/vst2/Vst2PluginInstance.h:6:10: fatal error: 'public.sdk/source/vst2.x/audioeffectx.h' file not found
#include "public.sdk/source/vst2.x/audioeffectx.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

asimilon · 2018-12-19T14:03:41Z

Must be something like permissions, or something else borked on your system.

Just successfully built in a clean clone.

$ env | grep VST
VST2SDK_DIR=/Users/asimilon/Documents/vst2_sdk/

asimilon · 2018-12-19T14:05:34Z

What is your exact output from env | grep VST?

I'm wondering if maybe you miss a trailing /
edit: that shouldn't make much difference though tbh

esaruoho · 2018-12-19T14:10:40Z

@asimilon hi

$ env | grep VST
VST24SDK=~/work/VST2.4SDK
VST2SDK_DIR=~/work/VST2.4SDK

esaruoho · 2018-12-19T14:11:00Z

(VST24SDK is there just because i'm trying to stab in the dark and figure out wth is going on)

esaruoho · 2018-12-19T14:11:31Z

about the trailing / - all the paths in premake5.lua are built to automatically add the / into the mix.

asimilon · 2018-12-19T14:24:32Z

Permissions perhaps then? It unfortunately is something that's confined to your system :(

baconpaul · 2018-12-20T00:25:57Z

Hey @esaruoho did this get sorted for you? It really does seem to be local-to-you.

If not, could you try a clean checkout at master maybe? Or let us know latest error message?

And if so, could you close the ticket?

Thanks!

esaruoho · 2018-12-20T00:40:43Z

I actually do trash the surge local repo on my drive pretty much daily just to make sure i don't have anything getting wrecked.
even after completely deleting the whole folder and cloning, i will get the same error. i wonder what i'm missing.

esaruoho · 2018-12-20T00:40:57Z

i will do a clean checkout on master and paste what i get. just a sec

esaruoho · 2018-12-20T01:14:06Z

ok.. here's the freshest errors:

error1

In file included from 
/Users/esaruoho/work/surge/src/common/SurgeSynthesizer.cpp
:
23
:

/Users/esaruoho/work/surge/src/vst2/Vst2PluginInstance.h
:
6:10
:
 
fatal error: 'public.sdk/source/vst2.x/audioeffectx.h' file
 
not
 found
#include "public.sdk/source/vst2.x/audioeffectx.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

1 error generated.

error2

In file included from /Users/esaruoho/work/surge/vst3sdk/vstgui4/vstgui/plugin-bindings/aeffguieditor.cpp:6:
/Users/esaruoho/work/surge/vst3sdk/vstgui4/vstgui/plugin-bindings/aeffguieditor.h:9:10: fatal error: 'public.sdk/source/vst2.x/aeffeditor.h' file not found
#include "public.sdk/source/vst2.x/aeffeditor.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

error3:

In file included from /Users/esaruoho/work/surge/src/vst2/Vst2PluginInstance.cpp:5:
src/vst2/Vst2PluginInstance.h:6:10: fatal error: 'public.sdk/source/vst2.x/audioeffectx.h' file not found
#include "public.sdk/source/vst2.x/audioeffectx.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

error4:

In file included from src/common/gui/SurgeGUIEditor.h:16:
vst3sdk/vstgui4/vstgui/plugin-bindings/aeffguieditor.h:9:10: fatal error: 'public.sdk/source/vst2.x/aeffeditor.h' file not found
#include "public.sdk/source/vst2.x/aeffeditor.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

and last error

Creating VST Bundle...
cp: 
target/vst2/Release/Surge.dylib: No such file or directory

** BUILD FAILED **

basically, looks like my "why yes, the folder is in ~/work/VST2.4SDK" doesn't work.

now, what i COULD do, is try and use an implicit url (explicit url?)

export VST2SDK_DIR="/Users/esaruoho/work/VST2.4SDK"

let's see what happens this time.

... well, what do you know - it works:

pro-tip: don't use ~/work/VST2.4SDK, instead use direct URLs. then it'll work. closing ticket.

also, how was i supposed to know this? :'(

esaruoho · 2018-12-20T01:14:39Z

thanks for the handholding, @baconpaul , i guess i learned quite a bit on this one :)

baconpaul · 2018-12-20T01:18:39Z

Well I'm not sure how anyone is supposed to know anything. But the problem you are having is the use of "" in shell which stops expansion.

Compare:

paul:~/dev/music/surge$ export DONTEXPAND="~/dev/music"
paul:~/dev/music/surge$ export DO_EXPAND=~/dev/music
paul:~/dev/music/surge$ echo $DONTEXPAND
~/dev/music
paul:~/dev/music/surge$ echo $DO_EXPAND
/Users/paul/dev/music

~ is shell expanded and so if you don't know the expansion rules it can burn you. But a short version of the expansion rules is "in quotes it doesn't expand". And then the tools downstream look for absolute paths. Hope that helps.

esaruoho · 2018-12-20T07:24:52Z

awesome! thanks! ...i really really should've thought of this one for sure.

thanks for the expanded explanation, too. all I can say is TIL to this one :)

type fix: change nsvg__parseLineJoin() default value to NSVG_JOIN_MITER

esaruoho mentioned this issue Dec 19, 2018

Surge-VST2: files in public.sdk/source/vst2.x not found #110

Closed

esaruoho changed the title ~~Surge-VST2: build-osx.sh: cp: target/vst2/Release/Surge.dylib: No such file or directory~~ Surge-VST2: build-osx.sh: VST2.4SDK not correctly referenced, so Surge.dylib not correctly built Dec 19, 2018

esaruoho mentioned this issue Dec 19, 2018

Surge-VST2: (macOS) Modify premake5.lua to conform to changes in surge-vst2.xcodeproj in asimilon branch #86

Closed

esaruoho closed this as completed Dec 20, 2018

baconpaul pushed a commit that referenced this issue Oct 2, 2020

Merge pull request #113 from martinlindhe/master

1f17a7e

type fix: change nsvg__parseLineJoin() default value to NSVG_JOIN_MITER

bobobo199733 mentioned this issue Mar 5, 2024

surge - 2018-09-25 - 2019-02-28 bobobo199733/issues-metrics-tool-repo#9

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Surge-VST2: build-osx.sh: VST2.4SDK not correctly referenced, so Surge.dylib not correctly built #113

Surge-VST2: build-osx.sh: VST2.4SDK not correctly referenced, so Surge.dylib not correctly built #113

esaruoho commented Dec 19, 2018 •

edited

Loading

esaruoho commented Dec 19, 2018 •

edited

Loading

esaruoho commented Dec 19, 2018

kzantow commented Dec 19, 2018 •

edited

Loading

esaruoho commented Dec 19, 2018

esaruoho commented Dec 19, 2018

asimilon commented Dec 19, 2018 •

edited

Loading

esaruoho commented Dec 19, 2018

asimilon commented Dec 19, 2018

asimilon commented Dec 19, 2018 •

edited

Loading

esaruoho commented Dec 19, 2018

esaruoho commented Dec 19, 2018

esaruoho commented Dec 19, 2018

asimilon commented Dec 19, 2018

baconpaul commented Dec 20, 2018

esaruoho commented Dec 20, 2018

esaruoho commented Dec 20, 2018

esaruoho commented Dec 20, 2018

esaruoho commented Dec 20, 2018

baconpaul commented Dec 20, 2018

esaruoho commented Dec 20, 2018 •

edited

Loading

Surge-VST2: build-osx.sh: VST2.4SDK not correctly referenced, so Surge.dylib not correctly built #113

Surge-VST2: build-osx.sh: VST2.4SDK not correctly referenced, so Surge.dylib not correctly built #113

Comments

esaruoho commented Dec 19, 2018 • edited Loading

esaruoho commented Dec 19, 2018 • edited Loading

esaruoho commented Dec 19, 2018

kzantow commented Dec 19, 2018 • edited Loading

esaruoho commented Dec 19, 2018

esaruoho commented Dec 19, 2018

asimilon commented Dec 19, 2018 • edited Loading

esaruoho commented Dec 19, 2018

asimilon commented Dec 19, 2018

asimilon commented Dec 19, 2018 • edited Loading

esaruoho commented Dec 19, 2018

esaruoho commented Dec 19, 2018

esaruoho commented Dec 19, 2018

asimilon commented Dec 19, 2018

baconpaul commented Dec 20, 2018

esaruoho commented Dec 20, 2018

esaruoho commented Dec 20, 2018

esaruoho commented Dec 20, 2018

esaruoho commented Dec 20, 2018

baconpaul commented Dec 20, 2018

esaruoho commented Dec 20, 2018 • edited Loading

esaruoho commented Dec 19, 2018 •

edited

Loading

esaruoho commented Dec 19, 2018 •

edited

Loading

kzantow commented Dec 19, 2018 •

edited

Loading

asimilon commented Dec 19, 2018 •

edited

Loading

asimilon commented Dec 19, 2018 •

edited

Loading

esaruoho commented Dec 20, 2018 •

edited

Loading