Surge-VST2: (macOS) Modify premake5.lua to conform to changes in surge-vst2.xcodeproj in asimilon branch

[esaruoho]

Here's a branch by @asimilon https://github.com/asimilon/surge/tree/macOS_VST2_build

This has a modified surge-vst2.xcodeproj - some of these modifications should somehow be emigrated into premake5.lua so that they don't need to be done by hand, instead created when running build-osx.sh.
Anyone?

[asimilon]

If anyone can point me at some decent documentation or tutorials for premake5 and targeting XCode I could take a stab at it, but I didn't find any useful information anywhere so far.
Also not sure if at all possible, but would be necessary to have 2 options for XCode : 1 for XCode9/brew llvm combo, the other for XCode10. It would also require some #ifdef throughout the code for those 2 targets.

[esaruoho]

@asimilon.. what i'm wondering is if i should maybe clone the surge repo as it is, then bake a surge-vst2.xcodeproj and do a Kaleidoscope (app) compare between the files, since they seem to be textfiles. That would at least give me the flags required :)

[asimilon]

I have made the correct changes on my fork (pushed to master branch).
AU and VST2 are building correctly and work, VST3 is building and linking, but is not recognised by Reaper, will investigate further.

edit : just seen in the package-vst3.sh this line :
PACKAGE_SRC_LOCATION="$RES_SRC_LOCATION/osx-vst2"
that can't be good! Checked with one of my own plugins and there is no difference between these files in VST2/3, so that was a ringer. Script was grabbing the wrong target file, but that didn't help either.

[asimilon]

I'm doubting my own sanity now, have created a Packages based installer for macOS, and the VST3 is working in Reaper, but the VST2 is not showing up, however it works fine in Live10 (which doesn't support VST3, so go figure).
pluginval won't even accept the AU or VST3 (and doesn't give any reason!), but auval passes.

[esaruoho]

for some reason, build-osx.sh will not build a vst2..
target/vst2/Release/surge.dylib never appears.

so

Creating VST Bundle...
cp: target/vst2/Release/Surge.dylib: No such file or directory

** BUILD FAILED **

not sure how to encourage the building of vst2 :o

[esaruoho]

logged that ticket at #113 .. not sure what's going on here. maybe i should close this ticket just in case.