Unicode SF2 and Multis #1301
Comments
baconpaul
added a commit
to baconpaul/shortcircuit-xt
that referenced
this issue
Sep 11, 2024
The reset mechanism used to try to remove everything bit by bit. error prone. Instead, do the obbious thing of unstream a blank engine state. Unfortunatley we can't with current APIs do a Multi from a memory stream only a file, so rather than just embed a multi make a little helper program to just make raw binary of engine state and put it in resources etc... Closes surge-synthesizer#1301 Closes surge-synthesizer#1162 Closes surge-synthesizer#1123
baconpaul
added a commit
that referenced
this issue
Sep 11, 2024
The reset mechanism used to try to remove everything bit by bit. error prone. Instead, do the obbious thing of unstream a blank engine state. Unfortunatley we can't with current APIs do a Multi from a memory stream only a file, so rather than just embed a multi make a little helper program to just make raw binary of engine state and put it in resources etc... Closes #1301 Closes #1162 Closes #1123
|
Possibly related but under windows, other format files (MP3, WAV) also fail to load for non-english characters. Not sure if Unicode but for example: |
|
I'm able to load a WAV without problem at head. There's one in the test samples set which has no problem. I have not tried MP3. I just got SF2 working though. |
|
Confirmed MP3 broken and will fix it with my next push along with SF2. |
baconpaul
added a commit
to baconpaul/shortcircuit-xt
that referenced
this issue
Sep 30, 2024
for mp3, sf2, scm and scp Closes surge-synthesizer#1301
baconpaul
added a commit
that referenced
this issue
Sep 30, 2024
* Unicode paths on windows correctly handled for mp3, sf2, scm and scp Closes #1301 * turn off clap val for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
On windows load an sf2 called "foo 🤣💕❤️❤️.sf2" or try and save a multi with that name and it fails
this is because we use libgig which gets unicode on windows wrong internally
the error message retains the emojis so it's somewhere inside where it does CreateFile and stuff as opposed to CreateFileA.
Nightmare fuel.
The text was updated successfully, but these errors were encountered: