Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset Engine Crash #1162

Closed
baconpaul opened this issue Aug 20, 2024 · 0 comments · Fixed by #1309
Closed

Reset Engine Crash #1162

baconpaul opened this issue Aug 20, 2024 · 0 comments · Fixed by #1309

Comments

@baconpaul
Copy link
Contributor

baconpaul commented Aug 20, 2024

I got a wierd crash today (b6f9eac) with reset engine that I didn't chase but want to write down

Have a patch with bus effects in place
Reset the engine
Add a sample
play it with the onscreen keyboard

blammo.

But
Have a patch with bus effects in place
Reset the engine
Quit and restart the session (so stream and unstream the empty engine)
Add a sample
play it with the onscreen keyboard

joy

so I think the 'clear bus' part of the reset engine is still not tearing down something. Probably need to reset an effect / de-initialize an effect.

baconpaul added a commit to baconpaul/shortcircuit-xt that referenced this issue Sep 11, 2024
The reset mechanism used to try to remove everything bit by
bit. error prone.

Instead, do the obbious thing of unstream a blank engine state.

Unfortunatley we can't with current APIs do a Multi from a memory
stream only a file, so rather than just embed a multi make a little
helper program to just make raw binary of engine state and put it
in resources etc...

Closes surge-synthesizer#1301
Closes surge-synthesizer#1162
Closes surge-synthesizer#1123
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant