Static Analyzer Fixes

Closes #1452 Closes #1453
surge-synthesizer · Nov 21, 2024 · 6198474 · 6198474
1 parent f3d08c7
commit 6198474
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/src-ui/app/browser-ui/BrowserPane.cpp b/src-ui/app/browser-ui/BrowserPane.cpp
@@ -340,7 +340,7 @@ struct DriveFSListBoxRow : public juce::Component
 
         isMouseDownWithoutDrag = false;
 
-        if (!isDragging && e.getDistanceFromDragStart() > 1.5f)
+        if (!isDragging && e.getDistanceFromDragStart() > 2)
         {
             stopPreview();
             if (auto *container = juce::DragAndDropContainer::findParentDragContainerFor(this))

diff --git a/src-ui/app/edit-screen/components/GroupTriggersCard.cpp b/src-ui/app/edit-screen/components/GroupTriggersCard.cpp
@@ -106,7 +106,7 @@ struct GroupTriggersCard::ConditionRow : juce::Component, HasEditor
                 a2M.reset();
             }
             else if ((int)sr.id >= (int)engine::GroupTriggerID::MACRO &&
-                     (int)sr.id <= (int)engine::GroupTriggerID::MACRO + scxt::macrosPerPart)
+                     (int)sr.id < (int)engine::GroupTriggerID::MACRO + scxt::macrosPerPart)
             {
                 auto dm = datamodel::pmd()
                               .asFloat()

diff --git a/src-ui/app/edit-screen/components/GroupZoneTreeControl.h b/src-ui/app/edit-screen/components/GroupZoneTreeControl.h
@@ -318,7 +318,7 @@ template <typename SidebarParent, bool fz> struct GroupZoneListBoxModel : juce::
             if (!isZone())
                 return;
 
-            if (!isDragging && e.getDistanceFromDragStart() > 1.5f)
+            if (!isDragging && e.getDistanceFromDragStart() > 2)
             {
                 if (auto *container = juce::DragAndDropContainer::findParentDragContainerFor(this))
                 {

diff --git a/src-ui/app/edit-screen/components/ProcessorPane.cpp b/src-ui/app/edit-screen/components/ProcessorPane.cpp
@@ -1196,7 +1196,7 @@ void ProcessorPane::itemDropped(const juce::DragAndDropTarget::SourceDetails &dr
 
 void ProcessorPane::mouseDrag(const juce::MouseEvent &e)
 {
-    if (!isDragging && e.getDistanceFromDragStart() > 1.5f)
+    if (!isDragging && e.getDistanceFromDragStart() > 2)
     {
         if (auto *container = juce::DragAndDropContainer::findParentDragContainerFor(this))
         {

diff --git a/src-ui/app/edit-screen/components/mapping-pane/ZoneLayoutDisplay.cpp b/src-ui/app/edit-screen/components/mapping-pane/ZoneLayoutDisplay.cpp
@@ -298,7 +298,7 @@ void ZoneLayoutDisplay::mouseDrag(const juce::MouseEvent &e)
 {
     if (mouseState == DRAG_SELECTED_ZONE)
     {
-        if (e.getDistanceFromDragStart() < 2)
+        if (e.getDistanceFromDragStart() <= 2)
         {
             return;
         }
-Original file line number
+Diff line change
@@ Expand Up @@
     {
         if (mouseState == DRAG_SELECTED_ZONE)
         {
-            if (e.getDistanceFromDragStart() < 2)
+            if (e.getDistanceFromDragStart() <= 2)
             {
                 return;
             }
@@ Expand Down @@