Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ranges intersect #1453

Closed
Dave-Lowndes opened this issue Nov 21, 2024 · 1 comment · Fixed by #1455
Closed

Ranges intersect #1453

Dave-Lowndes opened this issue Nov 21, 2024 · 1 comment · Fixed by #1455

Comments

@Dave-Lowndes
Copy link

shortcircuit-xt/src-ui/app/edit-screen/components/GroupTriggersCard.cpp

Line 108 in 10a872a

else if ((int)sr.id >= (int)engine::GroupTriggerID::MACRO &&

The range of values in L108 & L128 overlap.
Should the upper values be < rather than <= ?
@baconpaul
Copy link
Contributor

yes i think that is correct. I'm in the code this afternoon let me confirm and merge. but it certainly looks like it should be < not <=.

baconpaul added a commit to baconpaul/shortcircuit-xt that referenced this issue Nov 21, 2024
@baconpaul
Static Analyzer Fixes
6198474 
Closes surge-synthesizer#1452
Closes surge-synthesizer#1453
@baconpaul baconpaul mentioned this issue Nov 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Static Analyzer Fixes baconpaul/shortcircuit-xt
2 participants
@baconpaul @Dave-Lowndes