Updating my repo #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we faked a single "video/mp4" variant for all src= playbacks. This resulted in a failure when someone tried to use src= with encrypted WebM and ClearKey. The correct MIME type and codec needs to be sent to DrmEngine so that it can send the correct metadata to EME. Closes #3366 Change-Id: If4f12e0a800d07e84caaae0f6322f549a90b2a95
The "License Header" in custom content was an h3 element, and it was huge. This makes it a div with a more reasonable style. It seems better to me to use div instead of h3, since h3 implies a third-level of a hierarchy that does not exist here. Change-Id: I1f8c115a768924f827c5c87dc59bf4146e5e54d1
When switching from using document.createEvent to using the CustomEvent constructor, we accidentally broke the "shaka-ui-load-failed" event such that it no longer had a detail object. The detail object is meant to be provided, not by itself, but as a member variable inside a custom dictionary. This fixes the syntax on the constructor. Issue #3388 Change-Id: I16dc025c21c8f0a012b5854bbbc56e8b110b2300
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screenshots (optional)
Type of change
not work as expected)
Checklist:
./build/all.pyand the build passes./build/test.pyand all tests pass