Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FairPlay DRM updates #3347

Merged
merged 11 commits into from
May 5, 2021
Merged

FairPlay DRM updates #3347

merged 11 commits into from
May 5, 2021

Conversation

avelad
Copy link
Member

@avelad avelad commented Apr 19, 2021 •
edited
Loading

Related to: #3346

calvin-smith1
calvin-smith1 approved these changes Apr 25, 2021
View reviewed changes
Copy link

@calvin-smith1 calvin-smith1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

TheModMaker
TheModMaker suggested changes Apr 26, 2021
View reviewed changes
lib/player.js Outdated Show resolved Hide resolved
lib/media/drm_engine.js Outdated Show resolved Hide resolved
lib/media/drm_engine.js Outdated Show resolved Hide resolved
lib/media/drm_engine.js Outdated Show resolved Hide resolved
@avelad avelad requested a review from TheModMaker April 28, 2021 06:13
@avelad avelad requested a review from joeyparrish April 29, 2021 14:16
@joeyparrish
Copy link
Member

It's not clear to me how close this gets us to full support for MSE + Fairplay. This is a first step, but there is more to do? Can you clarify what this step gets us, and what steps are left after this?

@shaka-bot
Copy link
Collaborator

All tests passed!

@avelad
Copy link
Member Author

avelad commented Apr 29, 2021

@joeyparrish

This step brings us closer to Apple's examples of how to use FairPlay in src=.

The MSE part is advanced, I have not yet managed to make it work but I hope to have it soon (I have not gotten the encrypted event, but by falsifying the response I have already got it to work). I had thought of separating it into different PR to make it easier to review, if you think the opposite is better, let me know.

Note: I have a high workload now and in the next two weeks (I also need to integrate release 3.1). So it is likely that until mid-May I will not be able to send the following PR related to this (unless I change my priorities :))

@shaka-bot
Copy link
Collaborator

All tests passed!

@joeyparrish joeyparrish merged commit 46b1cfa into shaka-project:master May 5, 2021
@avelad avelad deleted the fairplay-drm-updates branch May 6, 2021 06:01
ismena pushed a commit that referenced this pull request May 17, 2021
@ismena
feat: Progress toward FairPlay DRM w/ MSE (#3347)
31ba8d3 
Related to: #3346
joeyparrish added a commit that referenced this pull request Jun 16, 2021
@joeyparrish
Revert "feat: Progress toward FairPlay DRM w/ MSE (#3347)"
0324177 
This reverts commit 31ba8d3.

This should not have been cherry-picked to a release branch.
@renovate renovate bot mentioned this pull request Jul 14, 2021
Merged
1 task
tecteun pushed a commit to tecteun/shaka-player that referenced this pull request Feb 10, 2022
@joeyparrish @tecteun
Revert "feat: Progress toward FairPlay DRM w/ MSE (shaka-project#3347)"
211dc74 
This reverts commit 31ba8d3.

This should not have been cherry-picked to a release branch.
tecteun pushed a commit to tecteun/shaka-player that referenced this pull request Feb 10, 2022
@joeyparrish @tecteun
Revert "feat: Progress toward FairPlay DRM w/ MSE (shaka-project#3347)"
e29164d 
This reverts commit 31ba8d3.

This should not have been cherry-picked to a release branch.
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@calvin-smith1 calvin-smith1 calvin-smith1 approved these changes

@joeyparrish joeyparrish joeyparrish approved these changes

@TheModMaker TheModMaker Awaiting requested review from TheModMaker

Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@avelad @joeyparrish @shaka-bot @TheModMaker @calvin-smith1