Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created a MapHeader class #49

Merged
merged 1 commit into from
Sep 14, 2011
Merged

Created a MapHeader class #49

merged 1 commit into from
Sep 14, 2011

Conversation

khughitt
Copy link
Member

I created a separate MapHeader class to use in place of pyfits.core.Header class.

Reasoning:

  1. Having something more general provides us with a more natural way to add support for other (non-FITS) types of data such as JPEG 2000.

  2. Header-parsing logic (including WCS handling) can go here to avoid isolate it from other code.

Question:
Currently normalization of header tags is done both in the source-specific modules (e.g. sdo.py) and in solwcs. Each approach has it's advantages: by handling it in the source-specific files the logic is generally much shorter since you already know what the tag should look like. By handling it elsewhere (e.g. in MapHeader), you can avoid redundant code in the source-specific files, but have to check for many more different variations of each tag.

Should we continue using both approaches or just choose one? If both, which tags should be handled in the source-specific files and which ones should be handled more generally?

ehsteve added a commit that referenced this pull request Sep 14, 2011
@ehsteve
Merge pull request #49 from khughitt/master
cf22d29 
Created a MapHeader class
@ehsteve ehsteve merged commit cf22d29 into sunpy:master Sep 14, 2011
@wtbarnes wtbarnes mentioned this pull request Apr 11, 2023
Closed
Prtm2110 added a commit to Prtm2110/sunpy that referenced this pull request Aug 4, 2024
@Prtm2110
# This is a combination of 70 commits.
0e345f1 
# This is the 1st commit message:

added gallery

# This is the commit message sunpy#2:

solved commit issue

# This is the commit message sunpy#3:

Changelog

# This is the commit message sunpy#4:

label removed

# This is the commit message sunpy#5:

figure devdeps hash

# This is the commit message sunpy#6:

Revert "Experimental change"

This reverts commit 779e66a.

# This is the commit message sunpy#7:

unskip more tests

# This is the commit message sunpy#8:

Bug fix the 1.1.0 schema to allow non-VO units

# This is the commit message sunpy#9:

Update sunpy/tests/figure_hashes_mpl_382_ft_261_astropy_600_animators_111.json
# This is the commit message sunpy#10:

Increase the min asdf deps

# This is the commit message sunpy#11:

Pin out naughty setuptools

# This is the commit message sunpy#12:

Parse DN correctly in header helper (sunpy#7730)

* parse DN correctly in header helper

* changelog

* wrong changelog number

* revert parse_fits_unit move; simplify DN checking

* revert small changes

* more newlines

* Update sunpy/map/tests/test_header_helper.py

Co-authored-by: Nabil Freij <[email protected]>

* Update changelog/7730.bugfix.rst

---------

Co-authored-by: Nabil Freij <[email protected]>
# This is the commit message sunpy#13:

replace usages of ``copy_arrays`` with ``memmap`` (sunpy#7737)


# This is the commit message sunpy#14:

reorder and cull whatsnew

# This is the commit message sunpy#15:

whats new review comments

# This is the commit message sunpy#16:

Steal the example for spice.get_rotation_matrix

# This is the commit message sunpy#17:

Update to use minimum_dependencies

# This is the commit message sunpy#18:

Update tox.ini
# This is the commit message sunpy#19:

bump numpy for scipy

# This is the commit message sunpy#20:

bump packaging

# This is the commit message sunpy#21:

Update to use extra groups and undo pin on setuptools

# This is the commit message sunpy#22:

more packages

# This is the commit message sunpy#23:

modify arguments based on installed version of asdf

# This is the commit message sunpy#24:

extra fixes for oldestdeps

# This is the commit message sunpy#25:

Update pyproject.toml
# This is the commit message sunpy#26:

make XRTMap have default units of DN

# This is the commit message sunpy#27:

Update changelog/7744.bugfix.rst

Co-authored-by: Nabil Freij <[email protected]>
# This is the commit message sunpy#28:

zenodo

# This is the commit message sunpy#29:

Fix my affiliation
# This is the commit message sunpy#30:

more mailmap

# This is the commit message sunpy#31:

update json

# This is the commit message sunpy#32:

update release notes

# This is the commit message sunpy#33:

mailmap

# This is the commit message sunpy#34:

Add Zach

# This is the commit message sunpy#35:

Add Manit Singh info

# This is the commit message sunpy#36:

Fix my mistakes

# This is the commit message sunpy#37:

Update release numbers

# This is the commit message sunpy#38:

Keith

# This is the commit message sunpy#39:

Update last two

# This is the commit message sunpy#40:

Release v6.0.0

# This is the commit message sunpy#41:

minor suggestions

# This is the commit message sunpy#42:

minor changes again

# This is the commit message sunpy#43:

first animation

# This is the commit message sunpy#44:

added ref

# This is the commit message sunpy#45:

docfail-test

# This is the commit message sunpy#46:

Automatic package template update

# This is the commit message sunpy#47:

docfailing

# This is the commit message sunpy#48:

docfail

# This is the commit message sunpy#49:

minor changes and animation

# This is the commit message sunpy#50:

minor changes

# This is the commit message sunpy#51:

Add 6.0 and remove 5.X cron jobs
# This is the commit message sunpy#52:

plt.show added

# This is the commit message sunpy#53:

minor changes and changelog ref

# This is the commit message sunpy#54:

changelog ref

# This is the commit message sunpy#55:

changelog ref

# This is the commit message sunpy#56:

contourpy is added

# This is the commit message sunpy#57:

merge issue

# This is the commit message sunpy#58:

added unit nitpick
# This is the commit message sunpy#59:

fix for drms refactor

# This is the commit message sunpy#60:

add skip windows for broken test

# This is the commit message sunpy#61:

changelog

# This is the commit message sunpy#62:

minor changes

# This is the commit message sunpy#63:

ski ref updated

# This is the commit message sunpy#64:

matplotlib mkn v and conf.py

# This is the commit message sunpy#65:

tests

# This is the commit message sunpy#66:

back to mpl3.5 and contourpy added to toml

# This is the commit message sunpy#67:

tests new

# This is the commit message sunpy#68:

added removed part

# This is the commit message sunpy#69:

mpl to 3.6 and changelog

# This is the commit message sunpy#70:

contour 1.0,1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khughitt @ehsteve