Simplify _cm. #41
Simplify _cm. #41
Conversation
|
Some of the simplification in your code is great (though the new functions need documentation) but regarding some of the other modifications I was following the conventions used in matplotlib as such I am loathe to accept those changes. |
|
Nice. The results are not exactly the same, but small differences shouldn't matter too much. Have you tested the new colormaps to make sure they appear similar to the original ones? |
|
The numbers I had in there were copied directly from the IDL code in order to make sure that we had the same color tables in Python. If we like having exactly the same color tables is not necessary then small differences don't matter but if we do then they do. |
|
Also, it might not be too terrible to diverge from matplotlib some if we can do it better. The overall structure and result would still be the same, just what is going on under-the-hood would differ. |
|
Well, I've never been a huge fan of the AIA color tables to begin with, so minor differences wouldn't bother me too much. Florian's version is also 2.57Kb smaller... which doesn't hurt :) |
|
The prior code had the last value of r, g and b twice and [r|g|b] tuple were 257 items long. I assumed this was a mistake, was I wrong? |
|
r0, g0, b0 are the same as before, so apart from what I mentioned above, they are exactly the same color tables. |
|
Cool. I'm okay with changes. Your call, Steven. On Thu, Sep 8, 2011 at 1:22 PM, Florian Mayer <
|
|
I'm cool with it but more documentation is still needed for each function. |
# This is the 1st commit message: added gallery # This is the commit message sunpy#2: solved commit issue # This is the commit message sunpy#3: Changelog # This is the commit message sunpy#4: label removed # This is the commit message sunpy#5: figure devdeps hash # This is the commit message sunpy#6: Revert "Experimental change" This reverts commit 779e66a. # This is the commit message sunpy#7: unskip more tests # This is the commit message sunpy#8: Bug fix the 1.1.0 schema to allow non-VO units # This is the commit message sunpy#9: Update sunpy/tests/figure_hashes_mpl_382_ft_261_astropy_600_animators_111.json # This is the commit message sunpy#10: Increase the min asdf deps # This is the commit message sunpy#11: Pin out naughty setuptools # This is the commit message sunpy#12: Parse DN correctly in header helper (sunpy#7730) * parse DN correctly in header helper * changelog * wrong changelog number * revert parse_fits_unit move; simplify DN checking * revert small changes * more newlines * Update sunpy/map/tests/test_header_helper.py Co-authored-by: Nabil Freij <[email protected]> * Update changelog/7730.bugfix.rst --------- Co-authored-by: Nabil Freij <[email protected]> # This is the commit message sunpy#13: replace usages of ``copy_arrays`` with ``memmap`` (sunpy#7737) # This is the commit message sunpy#14: reorder and cull whatsnew # This is the commit message sunpy#15: whats new review comments # This is the commit message sunpy#16: Steal the example for spice.get_rotation_matrix # This is the commit message sunpy#17: Update to use minimum_dependencies # This is the commit message sunpy#18: Update tox.ini # This is the commit message sunpy#19: bump numpy for scipy # This is the commit message sunpy#20: bump packaging # This is the commit message sunpy#21: Update to use extra groups and undo pin on setuptools # This is the commit message sunpy#22: more packages # This is the commit message sunpy#23: modify arguments based on installed version of asdf # This is the commit message sunpy#24: extra fixes for oldestdeps # This is the commit message sunpy#25: Update pyproject.toml # This is the commit message sunpy#26: make XRTMap have default units of DN # This is the commit message sunpy#27: Update changelog/7744.bugfix.rst Co-authored-by: Nabil Freij <[email protected]> # This is the commit message sunpy#28: zenodo # This is the commit message sunpy#29: Fix my affiliation # This is the commit message sunpy#30: more mailmap # This is the commit message sunpy#31: update json # This is the commit message sunpy#32: update release notes # This is the commit message sunpy#33: mailmap # This is the commit message sunpy#34: Add Zach # This is the commit message sunpy#35: Add Manit Singh info # This is the commit message sunpy#36: Fix my mistakes # This is the commit message sunpy#37: Update release numbers # This is the commit message sunpy#38: Keith # This is the commit message sunpy#39: Update last two # This is the commit message sunpy#40: Release v6.0.0 # This is the commit message sunpy#41: minor suggestions # This is the commit message sunpy#42: minor changes again # This is the commit message sunpy#43: first animation # This is the commit message sunpy#44: added ref # This is the commit message sunpy#45: docfail-test # This is the commit message sunpy#46: Automatic package template update # This is the commit message sunpy#47: docfailing # This is the commit message sunpy#48: docfail # This is the commit message sunpy#49: minor changes and animation # This is the commit message sunpy#50: minor changes # This is the commit message sunpy#51: Add 6.0 and remove 5.X cron jobs # This is the commit message sunpy#52: plt.show added # This is the commit message sunpy#53: minor changes and changelog ref # This is the commit message sunpy#54: changelog ref # This is the commit message sunpy#55: changelog ref # This is the commit message sunpy#56: contourpy is added # This is the commit message sunpy#57: merge issue # This is the commit message sunpy#58: added unit nitpick # This is the commit message sunpy#59: fix for drms refactor # This is the commit message sunpy#60: add skip windows for broken test # This is the commit message sunpy#61: changelog # This is the commit message sunpy#62: minor changes # This is the commit message sunpy#63: ski ref updated # This is the commit message sunpy#64: matplotlib mkn v and conf.py # This is the commit message sunpy#65: tests # This is the commit message sunpy#66: back to mpl3.5 and contourpy added to toml # This is the commit message sunpy#67: tests new # This is the commit message sunpy#68: added removed part # This is the commit message sunpy#69: mpl to 3.6 and changelog # This is the commit message sunpy#70: contour 1.0,1
No description provided.