-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed all instances of "missing_axis" to "missing_axes" #157
Conversation
ping @Cadair. Your dream come true ;) |
Thanks @gnshafreak I will take a look later 😄 |
Hi @gnshafreak. This looks great. So that we don't break the API, you also add a @property
def missing_axis(self):
# Issue deprecation warning here with message "missing_axis has been deprecated by missing_axes and will no longer be supported after ndcube 2.0".
return self.missing_axes |
Thanks for the pull request @gnshafreak! I am a bot that checks pull requests for milestones and changelog entries. If you have any questions about what I am saying, please ask!
If there are any issues with this message, please report them here. |
Hi @gnshafreak. This deprecation warning looks good! I think this may be ready to merge. Depending on the reason for the circleci test failure. @Cadair @nabobalis pip seems to be failing to install something for the circleci tests. Is this a known issue with sunpy as well? https://circleci.com/gh/sunpy/ndcube/129?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link |
Yes, that is an upstream issue that should be fixed in the next pip release. |
Thanks @nabobalis! In that case, I think this PR is ready to merge! Any objects @Cadair? |
CHANGELOG.rst
Outdated
@@ -10,6 +10,7 @@ API-Breaking Changes | |||
New version: | |||
``crop_by_extra_coord(coord_name, min_coord_value, max_coord_value)``. | |||
[#142] | |||
- Changed all instances of "missing_axis" to "missing_axes" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete this line.
Add a file in the changelog/ directory called 157.feature.rst |
Description
Fixes #130