Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The missing_axis argument to NDCube and attribute name is a typo #130

Closed
Cadair opened this issue Sep 24, 2018 · 2 comments · Fixed by #157
Closed

The missing_axis argument to NDCube and attribute name is a typo #130

Cadair opened this issue Sep 24, 2018 · 2 comments · Fixed by #157

Comments

@Cadair
Copy link
Member

Cadair commented Sep 24, 2018

It really should be missing_axes (the plural). Changing this would obviously be a backwards incompatible change, but I feel like we should probably fix it?
@DanRyanIrish
Copy link
Member

I agree.

@Cadair
Copy link
Member Author

Cadair commented Sep 24, 2018

Also the keywords for the constructor are in the wrong order, in that the ones from NDData should be first.

@gnshafreak gnshafreak mentioned this issue Apr 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

changed all instances of "missing_axis" to "missing_axes" gnshafreak/ndcube
2 participants
@Cadair @DanRyanIrish