enhance: Skip updating the level that are already at the specified le…

…vel (milvus-io#35094) issue: milvus-io#34495 Signed-off-by: Cai Zhang <[email protected]> Signed-off-by: Sumit Dubey <[email protected]>
sumitd2 · Aug 6, 2024 · dcabc1b · dcabc1b
1 parent d5675d3
commit dcabc1b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/internal/datacoord/compaction_task_clustering.go b/internal/datacoord/compaction_task_clustering.go
@@ -200,6 +200,10 @@ func (t *clusteringCompactionTask) BuildCompactionRequest() (*datapb.CompactionP
 
 func (t *clusteringCompactionTask) processPipelining() error {
 	log := log.With(zap.Int64("triggerID", t.TriggerID), zap.Int64("collectionID", t.GetCollectionID()), zap.Int64("planID", t.GetPlanID()))
+	if t.NeedReAssignNodeID() {
+		log.Debug("wait for the node to be assigned before proceeding with the subsequent steps")
+		return nil
+	}
 	var operators []UpdateOperator
 	for _, segID := range t.InputSegments {
 		operators = append(operators, UpdateSegmentLevelOperator(segID, datapb.SegmentLevel_L2))

diff --git a/internal/datacoord/meta.go b/internal/datacoord/meta.go
@@ -787,6 +787,10 @@ func UpdateSegmentLevelOperator(segmentID int64, level datapb.SegmentLevel) Upda
 				zap.Int64("segmentID", segmentID))
 			return false
 		}
+		if segment.LastLevel == segment.Level && segment.Level == level {
+			log.Debug("segment already is this level", zap.Int64("segID", segmentID), zap.String("level", level.String()))
+			return true
+		}
 		segment.LastLevel = segment.Level
 		segment.Level = level
 		return true