enhance: Skip updating the level that are already at the specified level #35094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
added
dco-passed
|
@xiaocai2333 E2e jenkins job failed, comment |
xiaocai2333
force-pushed
the
skip_rewrite_l2_segment-m
branch
from
7ccaaff to
96a9941
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #35094 +/- ##
==========================================
+ Coverage 81.01% 81.03% +0.02%
==========================================
Files 1189 1189
Lines 143466 143496 +30
==========================================
+ Hits 116224 116285 +61
+ Misses 22827 22790 -37
- Partials 4415 4421 +6
|
sre-ci-robot
pushed a commit
that referenced
this pull request
Jul 31, 2024
…e specified level (#35093) issue: #34495 master pr: #35094 Signed-off-by: Cai Zhang <[email protected]>
xiaocai2333
force-pushed
the
skip_rewrite_l2_segment-m
branch
from
96a9941 to
40bacd6
Compare
…d level Signed-off-by: Cai Zhang <[email protected]>
xiaocai2333
force-pushed
the
skip_rewrite_l2_segment-m
branch
from
40bacd6 to
5b10f8d
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: czs007, xiaocai2333 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sumitd2
pushed a commit
to sumitd2/milvus
that referenced
this pull request
Aug 6, 2024
…vel (milvus-io#35094) issue: milvus-io#34495 Signed-off-by: Cai Zhang <[email protected]> Signed-off-by: Sumit Dubey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #34495