Remove support for input elements
#11
Conversation
|
I know it's ancient but I'd vote to merge this, @timkelty @giuseppeg? |
| elements. For `a` elements, you should remove the `href` attribute and prevent | ||
| JavaScript event handlers from firing. | ||
| N.B. You must also include the `disabled` attribute on `button` elements. For | ||
| `a` elements, you should remove the `href` attribute and prevent JavaScript |
There was a problem hiding this comment.
Why not use a span then? I try to advocate this as much as possible but it is a tough one to win :)
|
@simonsmith sounds good to me |
|
I don't think we should be endorsing an If it's clickable, it should be a My vote is to just wipe that whole line about As for dropping |
|
+1 merge and drop the "a" line |
|
Preventing default events is a valid use of JS I would say, but removing the |
|
https://github.com/suitcss/components-button/compare/PR/11 Look good? I'm thinking a major version bump too |
|
|
|
Merged in 7d8936c |
Fixes #6