-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for input
#6
Comments
Ruby on rails form helpers uses |
ok. probably best to wait on this for a bit then. thanks |
This is by no means compulsory, just seems to be the default that people use. Currently using the following for buttons: <%= form_for current_account do |f| %>
<%= f.button 'Submit', name: nil, class: 'Button' %>
<% end %> <%= button_tag 'Save', type: 'button', name: nil, class: 'Button' %> I would say it was safe to remove the |
👍 |
simonsmith
pushed a commit
that referenced
this issue
Oct 1, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Firefox's UA styles fix the line-height of
input
tonormal
. Can't remember the last time I've seeninput type="button|submit"
used instead ofbutton
, so the component could just depend on usingbutton
ora
and be a bit more flexible.Could change to using
line-height: inherit
.The text was updated successfully, but these errors were encountered: