Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for input #6

Closed
necolas opened this issue Oct 17, 2013 · 4 comments
Closed

Drop support for input #6

necolas opened this issue Oct 17, 2013 · 4 comments

Comments

@necolas
Copy link
Contributor

necolas commented Oct 17, 2013

Firefox's UA styles fix the line-height of input to normal. Can't remember the last time I've seen input type="button|submit" used instead of button, so the component could just depend on using button or a and be a bit more flexible.

Could change to using line-height: inherit.

@AntonTrollback
Copy link
Contributor

Ruby on rails form helpers uses input type="submit"

@necolas
Copy link
Contributor Author

necolas commented May 15, 2014

ok. probably best to wait on this for a bit then. thanks

@simonsmith
Copy link
Member

Ruby on rails form helpers uses input type="submit"

This is by no means compulsory, just seems to be the default that people use. Currently using the following for buttons:

<%= form_for current_account do |f| %>
  <%= f.button 'Submit', name: nil, class: 'Button' %>
<% end %>
<%= button_tag 'Save', type: 'button', name: nil, class: 'Button' %>

I would say it was safe to remove the input support if this is all that is holding it up

@AntonTrollback
Copy link
Contributor

👍

simonsmith pushed a commit that referenced this issue Oct 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants