Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Asyncs? #55

Closed
paulxtiseo opened this issue Apr 7, 2018 · 5 comments
Closed

Multiple Asyncs? #55

paulxtiseo opened this issue Apr 7, 2018 · 5 comments
Labels
Milestone

Comments

@paulxtiseo
Copy link

paulxtiseo commented Apr 7, 2018

When I use Aigle to promisifyAll(require('fs')) I end up with multiple leveled Async functions. For example, for readFile() I end up with:

readFile: [Function],
readFileAsync: [Function],
readFileAsyncAsync: [Function],
readFileAsyncAsyncAsync: [Function],

Path seems to fair worse on almsot all functions:

resolve: [Function: resolve],
resolveAsync: [Function],
resolveAsyncAsync: [Function],
resolveAsyncAsyncAsync: [Function],
resolveAsyncAsyncAsyncAsync: [Function],
resolveAsyncAsyncAsyncAsyncAsync: [Function],
resolveAsyncAsyncAsyncAsyncAsyncAsync: [Function],
resolveAsyncAsyncAsyncAsyncAsyncAsyncAsync: [Function]

Why?

PS: bluebird does not seem to suffer from this. I get one Async promise-returning function for each function in a library.

@suguru03
Copy link
Owner

suguru03 commented Apr 8, 2018

Thank you for the issue!
I reproduced it, it is a bug. 😢
If promisifyAll is called multiple times, the function creates new functions, I'm gonna fix it, thanks!

@suguru03 suguru03 added the bug label Apr 8, 2018
@suguru03 suguru03 modified the milestones: v1.11, v1.12 Apr 8, 2018
@suguru03
Copy link
Owner

suguru03 commented Apr 8, 2018

It is fixed. I'm gonna release it on v.1.12 😄

@suguru03 suguru03 closed this as completed Apr 8, 2018
@paulxtiseo
Copy link
Author

Sorry, but a followup Q: any ballpark idea on when v1.12 will be released?

@suguru03
Copy link
Owner

suguru03 commented Apr 8, 2018

I'm gonna release it on v1.12.0-alpha.3 today. :)
I was planning to release #22 on v1.12, but I will take time more. So, I'm gonna move it to v1.13 and release v1.12 sometime soon. 😄

@suguru03
Copy link
Owner

suguru03 commented Apr 8, 2018

I published v1.12.0-alpha.3 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants