Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions: Add Typescript Types #22

Open
nkrass opened this issue Sep 15, 2017 · 4 comments
Open

Suggestions: Add Typescript Types #22

nkrass opened this issue Sep 15, 2017 · 4 comments
Assignees
Milestone

Comments

@nkrass
Copy link

nkrass commented Sep 15, 2017

Hi @suguru03 have u thought about adding typescript types for the project?

@suguru03
Copy link
Owner

Hi @nkrass !
It is a good idea, but I'm not familiar with TypeScript.
I'll look into it, thanks! 😄

@suguru03 suguru03 added this to the v1.x milestone Jan 26, 2018
@suguru03 suguru03 self-assigned this Mar 5, 2018
@suguru03 suguru03 modified the milestones: v1.x, v1.12 Mar 23, 2018
@suguru03 suguru03 modified the milestones: v1.12, v1.13 Apr 8, 2018
@ORESoftware
Copy link

ORESoftware commented Feb 1, 2019

+1 it is better to just write the library in TS. TS is not hard - it's very similar to JS. I can help you convert to TS, I am very good with TS.

If you write the lib in TS, it's a big advantage and some people will prefer to use Aigle instead of Bluebird for that reason. Same goes for neo-async :)

@suguru03
Copy link
Owner

suguru03 commented Feb 1, 2019

@ORESoftware Thanks for the suggestion! It is a great idea, I also love TypeScript!
But I'm planning to apply big changes, so I need to investigate the conversion. ✍️

For now, I added some types here ( I need to add more...! )
https://github.com/suguru03/aigle/blob/master/typings/aigle.d.ts
It is released from v1.13.0, please try it! 😄

@ORESoftware
Copy link

ORESoftware commented Feb 1, 2019

Yeah TS will help you maintain the library - with types, small and big changes are easier.
Looks like you picked up TS - those types look really good - but I think it's better to just write the library itself in TS, that way the types and the library are always in sync

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants